Enhance desktop client access restriction documentation - #15484
Open
Rello wants to merge 4 commits into
Open
Conversation
Expanded the documentation on blocking desktop client access, detailing three methods: by client version, using File Access Control, and at the HTTP layer. Signed-off-by: Rello <Rello@users.noreply.github.com>
Contributor
📖 Documentation Preview📄 1 changed documentation pageLast updated: Mon, 24 Aug 2026 12:42:40 GMT |
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Expands documentation for restricting desktop client access through version settings, File Access Control, and HTTP-layer rules.
Changes:
- Documents minimum supported client versions.
- Adds File Access Control guidance and performance warnings.
- Adds HTTP-layer blocking examples and verification steps.
Suppressed comments (3)
admin_manual/desktop/restrictaccess.rst:33
- This new heading uses title case, but the repository style guide requires sentence case for headings (see
style_guide.rst:31-36). Please useFile access controlto match the documented convention.
File Access Control
admin_manual/desktop/restrictaccess.rst:57
- Please keep the section levels consistent here.
HTTP layeris introduced as an h3 underBlocking methods, but the content that follows (Identify desktop client requests,Choose the policy,nginx, and the other sections) remains at h2. The generated table of contents therefore makes those sections siblings ofBlocking methodsinstead of children of the HTTP-layer method. Restructure/relevel this section within the three-level limit specified bystyle_guide.rst:31-46.
HTTP layer
^^^^^^^^^^
admin_manual/desktop/restrictaccess.rst:30
- The server also applies
maximum.supported.desktop.version(documented with a default of99.99.99inadmin_manual/configuration_server/config_sample_php_parameters.rst:3816-3819), so a future client at or above99.0.0is not necessarily allowed. Please describe this as satisfying the minimum check rather than claiming that the client would be allowed.
whose version is ``99.0.0`` or higher would be allowed, so the setting should
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rello <Rello@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded the documentation on blocking desktop client access, detailing three methods: by client version, using File Access Control, and at the HTTP layer.