Closed
Conversation
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…ate migration plan Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
… and update related components Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
… and consolidate component imports Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…r` component and update related usages Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…in `Description` component Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…in Board and Stack components Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…nd implement `mountComponent` utility for improved component lifecycle management Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…gureDeckVue` and `mountVueRoot` utilities Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…ntax for improved reactivity Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…nd implementing navigation error handling Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
refactor: replace $router.push with pushRoute for navigation consistency refactor: remove Vue dependency from Vuex store modules for improved state management feat: implement configureDeckVuex for Vuex integration fix: update state mutations to use direct assignment instead of Vue.set for better performance Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…nce creation for Vue 3 compatibility Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…uex, and enhancing component mounting logic Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…ing in Vuex and router configurations Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…synchronizing local value updates Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…bility - Updated package.json to use Vue 3 and related libraries - Refactored components to use Composition API and updated lifecycle hooks - Replaced deprecated lifecycle hooks (beforeDestroy) with beforeUnmount - Adjusted imports for Nextcloud Vue components to match new structure - Improved event subscription management in various components - Cleaned up functional components and removed unnecessary props - Ensured consistent use of async/await in lifecycle methods Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…Vue 3 support Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…3 compatibility Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…erience Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…ved styling Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…roved reactivity Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…ed drag-and-drop handling Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…g state handling Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…accessibility and remove deprecated Vue 2 code Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…roved card menu functionality and remove unused component Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…proved template structure Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…roved layout Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
… and method for navigating to attachments Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…d, and removing unused vue-easymde and vue-smooth-dnd Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…data binding in Board and AppNavigation components Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…ctivity in DeckAppSettings, TagsTabSidebar, CardReferenceWidget, and CommentReferenceWidget components Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
… approach for improved consistency Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…ling across components Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…prove editor setup logic in Description component Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
… in card data Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
… Board components based on canCreate Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…ns for better reactivity Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Member
|
Hello There, just saw this flying around and I know it's only a PoC. Just wanted to mention that this is definitely to big of a pr to be reviewed. We've tried going that route already some time ago but the prs just get to big and it's not really a nice way to move. I would much prefer to start smaller here and do the possible migrations that we can easily do without changing the runtime first, to have a easier time moving to vue3. I've written up some things in the vue3 issue and an example pr for migrating stores to pinia(which imo is the best point to start the migration) exists as well here: #7790 |
Contributor
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why? Vue 3 was released in 2020 and this app is still on Vue 2. Updating this app to Vue 3 is essential to improve security, dependency compatibility and developer experience.
TODO