2way sync: Better view handling - #13494
Merged
Merged
Conversation
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13494.apk |
alperozturk96
requested changes
Sep 3, 2024
4 tasks
tobiasKaminsky
force-pushed
the
emptyList
branch
from
October 28, 2024 15:17
f318a33 to
69be600
Compare
Member
Author
|
/backport to stable-3.30 |
ZetaTom
requested changes
Oct 29, 2024
ZetaTom
left a comment
ZetaTom
left a comment
Collaborator
There was a problem hiding this comment.
Unfortunately, this change breaks the Internal two way sync screen on my device. No two way sync folder yet always appears even when multiple folders are set up for two way sync.
The InternalTwoWaySyncAdapter does, however, accurately reflect the number of folders when evaluating the following expressing using the debugging console: binding.list.adapter.itemCount.
- empty state Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com> Signed-off-by: Alper 脰zt眉rk <67455295+alperozturk96@users.noreply.github.com>
Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com> Signed-off-by: Alper 脰zt眉rk <67455295+alperozturk96@users.noreply.github.com>
Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com> Signed-off-by: Alper 脰zt眉rk <67455295+alperozturk96@users.noreply.github.com>
alperozturk96
force-pushed
the
emptyList
branch
from
October 29, 2024 08:27
cea7583 to
ea3d029
Compare
alperozturk96
approved these changes
Oct 29, 2024
ZetaTom
approved these changes
Oct 30, 2024
ZetaTom
left a comment
ZetaTom
left a comment
Collaborator
There was a problem hiding this comment.
Everything seems to work on my end.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.