fix(FilePickerBuilder): Fix paths returned in Promise by pick method#963
Merged
Conversation
skjnldsv
approved these changes
Aug 27, 2023
…d and reject if nothing is picked Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
force-pushed
the
fix/filepicker-return
branch
from
d31a45f to
57f40c0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and also fix reject if nothing is picked.
pickreturns invalid path, but buttoncallbackworks #948