Skip to content

fix: Use core preview controller for loading file previews and fallback to MDI icons#962

Merged
skjnldsv merged 2 commits into
masterfrom
fix/use-preview-controller
Aug 27, 2023
Merged

fix: Use core preview controller for loading file previews and fallback to MDI icons#962
skjnldsv merged 2 commits into
masterfrom
fix/use-preview-controller

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Aug 27, 2023

  • Use preview controller instead of deprecated OC API
  • Fallback to MDI 20px icons for files if there is no preview
  • Fix l10n issue: Translations in vue templates were not extracted

@susnux susnux added bug Something isn't working 3. to review labels Aug 27, 2023
@susnux susnux added this to the 5.0.0 milestone Aug 27, 2023
@susnux susnux requested a review from skjnldsv August 27, 2023 00:18
@susnux susnux mentioned this pull request Aug 27, 2023
15 tasks
@susnux susnux force-pushed the fix/use-preview-controller branch from d567442 to a56b131 Compare August 27, 2023 00:25
susnux added 2 commits August 27, 2023 03:02
…ck to MDI icons

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/use-preview-controller branch from a56b131 to 968240f Compare August 27, 2023 01:02
@skjnldsv
Copy link
Copy Markdown
Contributor

Awesome!!

Careful, no backports possible as this is a 28+ feature :)

@skjnldsv skjnldsv merged commit 237244f into master Aug 27, 2023
@skjnldsv skjnldsv deleted the fix/use-preview-controller branch August 27, 2023 08:31
@skjnldsv skjnldsv mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop MimeType.getIconUrl

2 participants