fix(FilePicker): Fix selecting rows using the keyboard#934
Merged
Conversation
Contributor
Author
skjnldsv
approved these changes
Aug 24, 2023
Contributor
Author
|
Not sure what to do here. Merge without tests? Is there some way to ignore the package exports? Last resort: Fork the project as like with vue-select? |
Contributor
Import with relative path. import xxx from '../../node_modules/webdav/dist/' |
Contributor
Author
This might work for apps or server, but not for libraries. You can not know that the package is installed at that location. As all of those are possible: or or |
Contributor
|
Indeed, I only tried with Apps |
1591cdf to
aa6ac5a
Compare
Contributor
Author
|
See #949 for a solution until it is fixed, after that one is merged, this can be rebased and should work :) |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…d (except for entering directories) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
96bc972 to
d19c22b
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting by keyboard was broken due to wrong event and key name.