Skip to content

msgpack unpacking does not memoize string keys #372

Description

@cfbolz

In most large msgpack messages, the same kind of object repeats many times, therefore the same keys appear again and again. Many json decoders exploit this and memoize/intern strings, to reduce the memory use of the resulting message and also to reduce decoding time, see for example in PyPy. Would there be interest in implementing this feature in msgpack? I'd be happy to do the implementation work, if so.

Activity

  1. cfbolz commented on Nov 13, 2019

    @cfbolz
    Author

    I had some time so I went ahead and created a pull request: #373

  2. added a commit that references this issue on Dec 3, 2019
    2c66689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions