Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
+ Coverage 29.70% 29.76% +0.05%
==========================================
Files 49 49
Lines 16662 16679 +17
Branches 8053 8062 +9
==========================================
+ Hits 4950 4964 +14
+ Misses 6793 6792 -1
- Partials 4919 4923 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
would you have a bit more context? where do you see this flag? thanks |
|
Hmm, we are using clang/clang++ on windows(not clang-cl), and using cmake to generate pch files. The compile command cmake output is just like in the test case I wrote. Except the file name changed by real file name on my disk. target_precompile_headers(foo PRIVATE ${foo_pch_headers}) |
|
OK, could you please add these info in the commit message ? |
While compiling pch file emited by cmake, flag --emit-pch and -x c++header should be handled
|
@sylvestre Just added a new line within commit message |
|
This PR/commit is a bit borked. It breaks PCH compilation when using the officially documented way of just specifiying |
Removes a redundant clone in the `tower-service::Service::call()` implementation, and reduces the amount of generated code. Does not break any user facing API.
No description provided.