Skip to content

Docs support Q3.6#158

Merged
tastelikefeet merged 8 commits intomodelscope:mainfrom
tastelikefeet:feat/q3.6
Apr 15, 2026
Merged

Docs support Q3.6#158
tastelikefeet merged 8 commits intomodelscope:mainfrom
tastelikefeet:feat/q3.6

Conversation

@tastelikefeet
Copy link
Copy Markdown
Collaborator

PR type

  • Bug Fix
  • New Feature
  • Document Updates
  • More Models or Datasets Support

PR information

Write the detail information belongs to this PR.

Experiment results

Paste your experiment result here(if needed).

@tastelikefeet tastelikefeet changed the title Support Q3.6 Docs support Q3.6 Apr 15, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default model from Qwen3.5-27B to Qwen3.6-35B-A3B across documentation, configuration files, and examples. It also renames the public encode method in the Template class to a private _encode method, updating internal calls and documentation accordingly. The review feedback highlights that renaming encode is a significant breaking change for users and custom subclasses, recommending that the method remain public to maintain API stability and improve ergonomics in example code.

Comment thread src/twinkle/template/base.py Outdated
Comment thread src/twinkle/template/base.py Outdated
Comment thread src/twinkle/sampler/base.py Outdated
Comment thread docs/source_en/Usage Guide/Train-as-a-Service.md Outdated
@tastelikefeet
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Twinkle framework to support Qwen3.6-35B-A3B, migrating model IDs across documentation, examples, and configurations. It significantly expands the documentation with new guides for components like Gym, Hub, and various Loss/Metric types. A key code change refactors the Template class to make encode a convenience wrapper for batch_encode when handling single trajectories, with corresponding updates applied throughout the codebase. Additionally, the requirement to join the Twinkle-Explorers organization for serverless training access has been removed. The review feedback correctly identifies several documentation examples that still reference Qwen3.5 and should be updated for consistency with the Qwen3.6 rollout.

Comment thread docs/source_en/Components/Dataset/LazyDataset.md
Comment thread docs/source_en/Components/Hub/Hub.md
Comment thread docs/source_en/Usage Guide/Quick-Start.md
Comment thread docs/source_zh/组件/Hub/Hub.md
Comment thread docs/source_zh/组件/数据集/LazyDataset.md
Comment thread docs/source_zh/使用指引/快速开始.md
@tastelikefeet tastelikefeet merged commit cb582ef into modelscope:main Apr 15, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants