v1.0.0: cherry-pick #5077 and #5078 onto the release branch by cliffhall · Pull Request #5086 · modelcontextprotocol/servers

cliffhall · 2026-10-10T05:52:34Z

Part of #5080

Targets the one-time release branch v2/release/1.0.0, not v2/main, by maintainer decision recorded on #5080: v1.0.0 ships the legacy-era servers on SDK 1.x, cut from d8120439.

Description

Cherry-picks the two milestone fixes that merged to v2/main after the cut, so they ship in 1.0.0:

d52c2231 (time: accept only exact IANA timezone keys on every platform #5077, closes time: test_get_current_time_errors fails on macOS (case-insensitive tz database) #5060): the time server accepts a timezone only when it is an exact IANA key, case included, on every platform. On macOS, zoneinfo resolved europe/warsaw through the case-insensitive APFS tz database.
d7388c64 (memory: expect Node 26's path-suffixed EISDIR message in persistence test #5078, closes memory: persistence EISDIR test fails on Node 26 (version-dependent error message) #5076): the memory persistence test expects Node 26's path-suffixed EISDIR message (test only).

Both applied cleanly (git cherry-pick -x). One adaptation commit follows: the #5077 test came from the SDK v2 tree, where the exception is MCPError; on this branch it is SDK 1.x's McpError, which the module already imports. The server change itself needed none.

Server Details

Server: time (behavior), memory (test only)
Changes to: get_zoneinfo / --local-timezone validation, README note; tests

Motivation and Context

#5060 and #5076 are in the v1.0.0 milestone; their fixes merged after the SDK v2 migration, which v1.0.0 no longer includes.

How Has This Been Tested?

$ npm run local:gate; echo EXIT=$?
EXIT=0   (the first run failed ruff on `MCPError` (F821); fixed by the adaptation commit)
$ uv run --frozen pytest tests/test_server.py -k rejects_a_key
1 passed

Client evidence for #5060 (the time server over stdio rejecting europe/warsaw and accepting Europe/Warsaw) is in the release ledger, re-run against this branch's tree.

Breaking Changes

None beyond the fix: a non-exact timezone key that only resolved on case-insensitive filesystems is now rejected there, as it always was on Linux.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

I have read the MCP Protocol Documentation (not applicable: no protocol surface changes)
My changes follow MCP security best practices
I have updated the server's README accordingly (carried by the cherry-pick)
I have added a changeset (not applicable: time is a Python server; memory change is test only)
I have tested this with an LLM client (driven over stdio in the release ledger)
My code follows the repository's style guidelines
New and existing tests pass locally
I have added appropriate error handling
I have documented all environment variables and configuration options (not applicable)

🤖 Generated with Claude Code

On macOS, zoneinfo resolves a key such as europe/warsaw through the case-insensitive APFS tz database, so the server accepted it where Linux rejects it, and test_get_current_time_errors failed locally. Check each key against available_timezones() in the tool path and in the --local-timezone validation. Closes #5060 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com> (cherry picked from commit d52c223) Signed-off-by: cliffhall <cliff@futurescale.com>

Node 26 appends the file path to the EISDIR read error, so the exact-match assertion in persistence.test.ts failed there. Expect the suffixed text on Node 26 and later and the bare text before, keeping the exact match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com> (cherry picked from commit d7388c6) Signed-off-by: cliffhall <cliff@futurescale.com>

The cherry-pick of d52c223 (#5077) comes from the SDK v2 tree, where the exception is MCPError. On v2/release/1.0.0 the server raises mcp.shared.exceptions.McpError, already imported by this test module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>

changeset-bot · 2026-10-10T05:52:38Z

⚠️ No Changeset found

Latest commit: 96ec9ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot

🟢 Approval recommended

The focused changes match the linked issues and include appropriate regression coverage and documentation.

0 open findings

What changed in this PR

Cherry-picks two milestone fixes onto the one-time v1.0.0 release branch.

Changes:

Enforces exact, case-sensitive IANA timezone keys and documents the behavior.
Adds timezone validation regression coverage.
Updates the memory persistence test for Node 26’s EISDIR message.

File	Description
`src/time/src/mcp_server_time/server.py`	Adds cached exact-key timezone validation.
`src/time/tests/test_server.py`	Tests rejection of unlisted timezone keys.
`src/time/tests/test_protocol.py`	Covers lowercase CLI timezone rejection.
`src/time/README.md`	Documents exact-key requirements.
`src/memory/__tests__/persistence.test.ts`	Handles Node-version-specific `EISDIR` text.

🧠 Review effort: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

cliffhall · 2026-10-10T05:55:22Z

Copilot round 1: clean (0 findings, approval recommended). Loop ended on the first clean round; merged.

cliffhall and others added 3 commits October 10, 2026 01:49

cliffhall added the v2 label Oct 10, 2026

cliffhall linked an issue Oct 10, 2026 that may be closed by this pull request

Release v1.0.0 #5080

Closed

7 tasks

cliffhall requested a balanced review from Copilot October 10, 2026 05:52

Copilot started reviewing on behalf of cliffhall October 10, 2026 05:53 View session

Copilot AI reviewed Oct 10, 2026

View reviewed changes

cliffhall mentioned this pull request Oct 10, 2026

v1.0.0: release audit for the SDK 1.x release branch #5087

Merged

10 tasks done

cliffhall merged commit 3f5e9ea into v2/release/1.0.0 Oct 10, 2026
31 checks passed

cliffhall deleted the v2/chore/5080-release-cherry-picks branch October 10, 2026 05:55

This was referenced Oct 10, 2026

v1.0.0: stamp Python CalVer versions for 2026.10.10 (release branch) #5089

Merged

Release v1.0.0: merge v2/release/1.0.0 into main #5090

Merged

Navigation Menu

Repository navigation

v1.0.0: cherry-pick #5077 and #5078 onto the release branch - #5086

v1.0.0: cherry-pick #5077 and #5078 onto the release branch#5086
cliffhall merged 3 commits into
v2/release/1.0.0from
v2/chore/5080-release-cherry-picks

cliffhall commented Oct 10, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

cliffhall commented Oct 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cliffhall commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Server Details

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

Checklist

Uh oh!

changeset-bot Bot commented Oct 10, 2026

⚠️ No Changeset found

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

cliffhall commented Oct 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cliffhall commented Oct 10, 2026 •

edited

Loading