Repository navigation
Conversation
Signed-off-by: unknown <bbdu3@iflytek.com>
bbdu3
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 4, 2026 08:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support deferred OAuth authorization for web applications, allowing the authorization code flow to resume through a subsequent callback request, including across different PHP workers.
Adds
RedirectAuthorizationHandler,AuthorizationPendingException, andOAuthAuthenticator::finishAuthorization(), with persistent, single-use authorization state and regression tests.Fixes #630.
Motivation and Context
AuthorizationHandlerInterface::authorize()currently expects callback parameters within the same call, which does not fit web applications where authorization redirects and callbacks are handled by separate HTTP requests.This change implements the approach :
AuthorizationPendingExceptionwith the authorization URL.finishAuthorization()to validate the response, exchange the authorization code, and store the tokens.Test
Unit tests
All 54
OAuthAuthenticatortests pass, covering cross-instance completion, PKCE context preservation, state validation and replay prevention, issuer validation, user storage isolation, andoffline_accessfallback.Storage tests cover interleaved writes, atomic consumption across instances, issuer-specific cleanup, and malformed records.
HTTP integration tests
All 10 OAuth integration tests pass against local authorization and MCP server fixtures.
The cross-process regression test verifies that:
Broader checks
git diff --checkpasses.Breaking Changes
None. Existing interfaces and synchronous authorization remain compatible.
CredentialStorageInterfaceis unchanged. Deferred authorization requires:PendingAuthorizationStorageInterface.AuthorizationPendingExceptionand redirecting to its authorization URL.finishAuthorization()before retrying the MCP operation.Types of Changes