Skip to content

Add implicit default origin in case of port 80 - #892

Closed
m-breitbach wants to merge 1 commit into
modelcontextprotocol:v1/mainfrom
m-breitbach:patch-1
Closed

Add implicit default origin in case of port 80#892
m-breitbach wants to merge 1 commit into
modelcontextprotocol:v1/mainfrom
m-breitbach:patch-1

Conversation

@m-breitbach

Copy link
Copy Markdown

Motivation and Context

In case of client port 80, origin http://localhost without explicit port should be accepted by default.

How Has This Been Tested?

Tested locally.

Breaking Changes

I would guess that nobody relies on that behavior.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

None.

@m-breitbach m-breitbach changed the title Add implicit version of port 80 default origin Add implicit default origin in case of port 80 Oct 28, 2025
@cliffhall cliffhall added the v1 label Apr 16, 2026
@cliffhall
cliffhall changed the base branch from main to v1/main July 28, 2026 03:07
@cliffhall

cliffhall commented Jul 31, 2026

Copy link
Copy Markdown
Member

Closing: v1 is deprecated.

Thank you for this contribution, and apologies for the long wait for a response.

v1 will receive security fixes only. We reviewed every open v1 PR for security impact before closing — see the backlog triage in #1819 — and a small number were retained for a final 1.0.5 patch release. This one is a functionality, compatibility, or cleanup change rather than a vulnerability fix, so it is being closed unmerged. This is not a judgment on the quality of the work — it's a consequence of the branch it targets being frozen.

If the underlying problem still exists in v2, we'd genuinely like to know. Please open an issue describing it against v2. Note that we accept external contributions as issues rather than pull requests — maintainers handle design and implementation through a prompt-driven workflow. See CONTRIBUTORS.md.

Thanks again for taking the time to contribute to the Inspector.

@cliffhall cliffhall closed this Jul 31, 2026
@cliffhall cliffhall added the closed-v1-deprecated Closed: v1 is deprecated and accepting security fixes only label Jul 31, 2026
@m-breitbach

m-breitbach commented Jul 31, 2026

Copy link
Copy Markdown
Author

The prompt(s) you used to generate the change.

So it is already out of question that one has made the changes by hand? Wtf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-v1-deprecated Closed: v1 is deprecated and accepting security fixes only v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants