Repository navigation
chore: add the project LICENSE and point every manifest at it - #2449
Conversation
v2 shipped with no LICENSE file anywhere in the repository or the npm tarball, while four manifests declared plain "MIT". Restore the state v1/main is in (#1017, #1036): the root LICENSE carries the MCP licensing-transition notice with the Apache-2.0, MIT and CC-BY-4.0 terms, the published manifest says "SEE LICENSE IN LICENSE", and the private client manifests point at the root file. README's License section now describes the file instead of saying "MIT." npm always packs a root LICENSE regardless of "files", so it lands in the tarball (verified with npm pack --dry-run). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The implementation is internally consistent, but adopting licensing terms requires final maintainer or legal confirmation.
Review effort: Balanced
Findings: None
What changed in this PR
Adds the project’s established licensing terms and aligns all manifests and documentation.
Changes:
- Adds the transition notice and Apache-2.0, MIT, and CC-BY-4.0 terms.
- Updates manifest metadata, lockfiles, and README guidance.
| File | Description |
|---|---|
LICENSE |
Adds the licensing terms used by v1 and the TypeScript SDK. |
README.md |
Summarizes and links the licensing terms. |
package.json |
Points published package metadata to LICENSE. |
package-lock.json |
Synchronizes root package metadata. |
clients/web/package.json |
Adds the root-license reference. |
clients/web/package-lock.json |
Synchronizes web metadata. |
clients/cli/package.json |
Replaces the MIT declaration with the root-license reference. |
clients/cli/package-lock.json |
Synchronizes CLI metadata. |
clients/tui/package.json |
Replaces the MIT declaration with the root-license reference. |
clients/tui/package-lock.json |
Synchronizes TUI metadata. |
clients/launcher/package.json |
Replaces the MIT declaration with the root-license reference. |
clients/launcher/package-lock.json |
Synchronizes launcher metadata. |
Files not reviewed (4)
- clients/cli/package-lock.json: Generated file
- clients/launcher/package-lock.json: Generated file
- clients/tui/package-lock.json: Generated file
- clients/web/package-lock.json: Generated file
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Copilot review round 1: no findings, and no inline or suppressed comments, so nothing to change and no further round requested. The overview's one note — that adopting licensing terms needs final maintainer/legal confirmation — is agreed and already called out in the PR body under For the maintainer: the |
Closes #2406
What changed
v2 had no LICENSE file anywhere, in the repository or the npm tarball, while four manifests declared plain
MIT. This PR puts v2 back in the statev1/mainis already in (#1017, #1036).LICENSE(new)v1/main's: the MCP licensing-transition notice, then the Apache-2.0 and MIT texts, then the CC-BY-4.0 pointer for docspackage.json(published)"MIT""SEE LICENSE IN LICENSE", the same value v1 usesclients/{cli,tui,launcher}/package.json"MIT""SEE LICENSE IN ../../LICENSE"clients/web/package.json"SEE LICENSE IN ../../LICENSE"package-lock.jsonroot entryREADME.mdLicense sectionMIT.LICENSEand summarizes the transition termsThe client manifests are
private: trueand are never published, so theirSEE LICENSE INpoints at the root file by relative path instead of a copy nobody ships.Tarball
npm always packs a root
LICENSE, whateverfilesand.npmignoresay..npmignoredoes not exclude it in any case. Verified:For the maintainer
The issue rightly says which text applies is a maintainer and legal decision. This PR copies v1's LICENSE verbatim, which is also the text
modelcontextprotocol/typescript-sdkcarries. If v2 should carry different terms, only theLICENSEfile and the README summary need to change; the manifest values stay the same either way.npm run local:gatepassed.🤖 Generated with Claude Code