Skip to content

enhance: add restful api to trigger component stop (#32076)#33798

Merged
sre-ci-robot merged 1 commit intomilvus-io:2.3from
weiliu1031:trigger_stop23
Jun 17, 2024
Merged

enhance: add restful api to trigger component stop (#32076)#33798
sre-ci-robot merged 1 commit intomilvus-io:2.3from
weiliu1031:trigger_stop23

Conversation

@weiliu1031
Copy link
Copy Markdown
Contributor

@weiliu1031 weiliu1031 commented Jun 12, 2024

issue: #32698
pr: #32076
This PR add two rest api for component stop and status check:

  1. /management/stop?role=querynode can stop the specified component
  2. /management/check/ready?role=rootcoord can check whether the target component is serviceable

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 12, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2024

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031
Copy link
Copy Markdown
Contributor Author

weiliu1031 commented Jun 13, 2024

rerun ut

@weiliu1031
Copy link
Copy Markdown
Contributor Author

weiliu1031 commented Jun 13, 2024

/run-cpu-e2e

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 13, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.00000% with 28 lines in your changes missing coverage. Please review.

Project coverage is 83.08%. Comparing base (636be02) to head (861209b).
Report is 6 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #33798      +/-   ##
==========================================
- Coverage   83.09%   83.08%   -0.02%     
==========================================
  Files         851      851              
  Lines      106729   106770      +41     
==========================================
+ Hits        88690    88708      +18     
- Misses      14737    14759      +22     
- Partials     3302     3303       +1
Files Coverage Δ
internal/distributed/proxy/service.go 82.45% <100.00%> (ø)
internal/proxy/management.go 87.86% <100.00%> (ø)
internal/http/server.go 62.50% <0.00%> (-33.66%) ⬇️

... and 10 files with indirect coverage changes

@weiliu1031
enhance: add restful api to trigger component stop (milvus-io#32076)
861209b 
issue: milvus-io#32698
This PR add two rest api for component stop and status check:
1. `/management/stop?role=querynode` can stop the specified component
2. `/management/check/ready?role=rootcoord` can check whether the target
component is serviceable

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 17, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Copy Markdown
Contributor Author

weiliu1031 commented Jun 17, 2024

/run-cpu-e2e

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 17, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Copy Markdown
Contributor Author

weiliu1031 commented Jun 17, 2024

/run-cpu-e2e

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 17, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

3 similar comments
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 17, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 17, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 17, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Copy Markdown
Contributor

jaime0815 commented Jun 17, 2024

/lgtm

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 17, 2024
@czs007
Copy link
Copy Markdown
Collaborator

czs007 commented Jun 17, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Copy Markdown
Contributor

sre-ci-robot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit deb2c78 into milvus-io:2.3 Jun 17, 2024
@yanliang567 yanliang567 added this to the 2.3.18 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@jaime0815 jaime0815

@czs007 czs007

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Milestone

2.3.18

Development

Successfully merging this pull request may close these issues.

5 participants

@weiliu1031 @jaime0815 @czs007 @sre-ci-robot @yanliang567