Skip to content

fix: [2.3] Write back dbid modification for nonDB id collection (#33641)#33695

Merged
sre-ci-robot merged 2 commits intomilvus-io:2.3from
congqixia:cp23/33641
Jun 11, 2024
Merged

fix: [2.3] Write back dbid modification for nonDB id collection (#33641)#33695
sre-ci-robot merged 2 commits intomilvus-io:2.3from
congqixia:cp23/33641

Conversation

@congqixia
Copy link
Copy Markdown
Contributor

Cherry-pick from master
pr: #33641
See also #33608

Make fixDefaultDBIDConsistency also write back collection dbid modification when nonDB id collection is found.

This fix shall prevent dropped collections of this kind show up again after dropping and restart.

…33641)

See also milvus-io#33608

Make `fixDefaultDBIDConsistency` also write back collection dbid
modification when nonDB id collection is found.

This fix shall prevent dropped collections of this kind show up again
after dropping and restart.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Jun 6, 2024
@sre-ci-robot sre-ci-robot requested review from xige-16 and zwd1208 June 6, 2024 11:32
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 6, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 6, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 6, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 7, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (636be02) to head (f7928e9).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #33695      +/-   ##
==========================================
+ Coverage   83.09%   83.10%   +0.01%     
==========================================
  Files         851      851              
  Lines      106729   106733       +4     
==========================================
+ Hits        88690    88704      +14     
+ Misses      14737    14724      -13     
- Partials     3302     3305       +3     
Files Coverage Δ
internal/metastore/kv/rootcoord/kv_catalog.go 89.10% <100.00%> (+0.05%) ⬆️

... and 17 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 7, 2024
Copy link
Copy Markdown
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9d6af07 into milvus-io:2.3 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants