Skip to content

enhance: [2.3] Print UseDefaultConsistency param in read requests (#33617)#33645

Merged
sre-ci-robot merged 1 commit intomilvus-io:2.3from
congqixia:cp23/33167
Jun 6, 2024
Merged

enhance: [2.3] Print UseDefaultConsistency param in read requests (#33617)#33645
sre-ci-robot merged 1 commit intomilvus-io:2.3from
congqixia:cp23/33167

Conversation

@congqixia
Copy link
Copy Markdown
Contributor

@congqixia congqixia commented Jun 5, 2024

Cherry-pick from master
pr: #33617
UseDefaultConsistency param is crucial for debugging slow query problems. It could be confusing when guarantee timestamp is 1 while this param is not logged

…o#33617)

`UseDefaultConsistency` param is crucial for debugging slow query problems.
It could be confusing when guarantee timestamp is 1 while this param is not logged

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Jun 5, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 5, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 5, 2024

@congqixia Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 5, 2024

@congqixia Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/missing-related-pr labels Jun 5, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.08%. Comparing base (168724b) to head (f125310).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #33645      +/-   ##
==========================================
- Coverage   83.09%   83.08%   -0.01%     
==========================================
  Files         851      851              
  Lines      106727   106729       +2     
==========================================
- Hits        88684    88676       -8     
- Misses      14738    14746       +8     
- Partials     3305     3307       +2     
Files Coverage Δ
internal/proxy/impl.go 85.53% <100.00%> (+<0.01%) ⬆️

... and 16 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 6, 2024
Copy link
Copy Markdown
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 636be02 into milvus-io:2.3 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed kind/enhancement Issues or changes related to enhancement lgtm needs-dco DCO is missing in this pull request. size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants