TypeScript Namespaces Release#184
Merged
Merged
Conversation
zengin
requested review from
MIchaelMainer,
baywet,
darrelmiller,
ddyett,
nikithauc and
peombwa
baywet
approved these changes
Aug 27, 2020
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
What Michael said for the namespace name, besides that, LGTM
Contributor
Author
|
Converting this to draft to get linting changes in as well. |
Contributor
Author
|
Republishing this PR, the commit a56ef88 is the one with the fixes from microsoftgraph/MSGraph-SDK-Code-Generator#279 |
Contributor
Author
nikithauc
approved these changes
Aug 28, 2020
baywet
approved these changes
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CallRecordsnamespace is exported as nested namespace.callRecordsproperty is added toCloudCommunicationsWork Items
AB#5029