Merged extensions and generated#214
Merged
Merged
Conversation
…ses and deleted Base*.java files of generated folders of models and extensions.
deepak2016
approved these changes
Jan 25, 2019
| import com.microsoft.graph.models.extensions.*; | ||
| import com.microsoft.graph.models.generated.*; | ||
| import com.microsoft.graph.http.*; | ||
| import com.microsoft.graph.requests.extensions.*; |
Contributor
There was a problem hiding this comment.
as this class is already in requests extensions folder, we don't need to do explicit import statement. We can take care of this in next set of check-ins.
Contributor
|
It is not practical to go over all files to review the code. I have done random sampling of few files and looked through them. Changes look good and given you have spent extensive amount testing the changes, I'm approving the changes. Thanks |
dadheech115
approved these changes
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Template changes link : microsoftgraph/MSGraph-SDK-Code-Generator#174