feat: Added statusCodesToTreatAsSuccess (additive success set) to NewBatchWithFailedRequests and Preserving RequestId

[Jeppe Mastrup Spanggaard (jeppesc11)]

Changes proposed in this pull request

• Preserving RequestId while using NewBatchWithFailedRequests
• Added statusCodesToTreatAsSuccess (additive success set) to NewBatchWithFailedRequests

Microsoft Reviewers: Open in CodeFlow

[Jeppe Mastrup Spanggaard (jeppesc11)]

@microsoft-github-policy-service agree

[Ramses Sanchez-Hernandez (ramsessanchez)]

Jeppe Mastrup Spanggaard (@jeppesc11) Can you provide reasons or issue reference for added context as to why we would want to maintain the same request id?

[Jeppe Mastrup Spanggaard (jeppesc11)]

Ramses Sanchez-Hernandez (@ramsessanchez) I can see that I should have explained why - apologies.

The reason is that, for example, with “Get file content” you don’t get an ID back that you can use to correlate with your requests -only the batch request ID. So if some number of the 20 calls in the batch fail and I then retry, I no longer have a way to correlate request and response.

I have previously written a longer blog post about this exact issue.

• https://jeppe-spanggaard.dk/blogs/graph-batching-file-content-mapping/
• https://jeppe-spanggaard.dk/blogs/graph-batch-smart-retry/

The reason for statusCodesToTreatAsSuccess is, again, that with “Get File Content” about 9 out of 10 times I get a response code indicating Redirect or Found. That means these will, by default, be retried - even though it’s a valid status code for this scenario. The same applies to 404.

[Jeppe Mastrup Spanggaard (jeppesc11)]

Looks fine with the changes made.