Java template fix to reduce memory footprint - continued#139
Merged
Conversation
…nerates ~600 files.
…enerates ~600 files.
…method for IBaseMethodRequest
…enerates ~200 files.
Contributor
Author
MIchaelMainer
approved these changes
Jun 26, 2018
Collaborator
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
Looks good. Is the reason why CreatePackageDefForIBaseEntityRequest exists in BaseJavaModel.template.tt instead of IBaseEntityRequest.java.tt is because all of the other content builders are in BaseJavaModel? On the surface, that helper seems like it should be in the template that uses it.
Contributor
Author
|
Yes, these helpers are template file specific and I think, I will move them out from BaseJavaModel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing import statements for IBaseEntityRequest template
Fixing import statements for IBaseMethodRequest template
Fixing import statements for BaseMethodRequest template
Together these templates impact ~1400 files and these files will start getting optimized import statements with this fix.
Testing:
After generating files using these templates, java sdk has started building with 2GB RAM.