feat(eval): add model cache controls - #1270
Open
xieofxie wants to merge 5 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 3, 2026
zhenchaoni
reviewed
Aug 4, 2026
zhenchaoni
left a comment
Member
There was a problem hiding this comment.
Reviewed the cache-control plumbing end to end and ran the affected suites on this branch (tests/unit/commands/test_eval.py, tests/unit/eval/test_eval.py, tests/unit/utils/test_cli.py, tests/unit/commands/test_perf_cli.py — 342 passed).
The core wiring is sound and the precedence outcome is currently correct. My main concerns are:
- The GenAI path is classified as "no build runs", but it does build and cache (
bundle_dir/_compiled/). Cache controls are silently dropped there and the user is told they were ignored. This one looks like a real bug. _model_build_skip_reasonre-implements_load_model's dispatch with different predicates, so the two can disagree.ignored_build_flags_warningchanged a keyword's name and inverted its meaning in one step — worth a second pair of eyes on the two call sites.- The stated precedence chain has no "CLI default" layer — it works today only because the Click defaults happen to equal the dataclass defaults, and nothing enforces that.
Details inline.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
winml evalwith cache reuse enabled by defaultReview notes
ignored_build_flags_warningnow accepts the positivebuild_runspredicate instead of the former inverseskip_build_onnxpredicate; all call sites were inverted with the rename._compiled/cache controls are tracked separately in Honor cache controls for GenAI runtime compilation #1275.perfcache migration is handled by stacked PR feat(perf): standardize cache controls #1271.Stack
Shared cache primitives landed in #1269.