Clarify some manifest values and add examples#6277
Open
sredna wants to merge 2 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
reviewed
Jun 11, 2026
JohnMcPMS
left a comment
Member
There was a problem hiding this comment.
The changes seem reasonable to me, but I don' actually touch the schema much so I would like someone else to take a look too.
The flow for semantic changes to the schema as part of a new minor version also requires quite a bit more setup. See #5997 and/or #5011.
I think I will also create some additional documentation to prevent the need for you to parse through those if you want to wait for that.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Notes:
UpgradeCodeis restricted only to GUIDs because this is a MSI feature. I have verified that all existing manifests in the community repository only uses GUIDs here.DefaultInstallLocationis restricted to strings starting with%or\. The thinking is that the only sane values are%ProgramFiles%\MyApp,%LOCALAPPDATA%\Programs\MyAppand\AppInRootOfDrive.🔗 References
Fixes some of the issues reported in #6221
🔍 Validation
None/YOLO
✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow