Repository navigation
Chat memory leak fixes - #308591
Merged
Merged
Chat memory leak fixes#308591
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses suspected chat-related memory leaks by ensuring more UI/template references and chat-editing entries are released, and by adding regression coverage in the ChatService test suite.
Changes:
- Add ChatService tests to exercise session switching / reference release scenarios.
- Adjust
ChatListItemRenderer.updateViewModel()ordering and cleanup to avoid retaining rendered template elements/pool items. - Dispose removed chat-editing entries when deleting a file from a
ChatEditingSession.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/test/common/chatService/chatService.test.ts |
Adds regression tests around chat model reference lifecycle and session switching behavior. |
src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts |
Clears additional template bookkeeping and fires view-model update before clearing pools; clears currentElement to release references. |
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingSession.ts |
Disposes the removed modified-file entry on delete to avoid retaining resources. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 2
Co-authored-by: Copilot <copilot@github.com>
Contributor
roblourens
marked this pull request as ready for review
April 8, 2026 21:16
roblourens
enabled auto-merge (squash)
April 8, 2026 21:16
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Johannes Rieken (@jrieken)Matched files:
|
Raymond Zhao (rzhao271)
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot copilot@github.com