Smoke tests in nodejs#6499
Closed
DonJayamanne wants to merge 112 commits intomicrosoft:masterfrom
Closed
Conversation
ericsnowcurrently
suggested changes
Jul 9, 2019
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Here's my initial review. It covers everything except:
src/smoke/src/uitests/
Also:
- presumably
src/smoke/vscode/is the code we copied and should not be reviewed. Is that right? - why are we keeping a
.vsixin the repo (why not rebuild it where needed) and how are we going to keep it up to date? - I'm not a fan of using the term "smoke tests" here. Smoke tests is the minimal subset of your full test suite that you can (relatively) quickly run to sanity-check the code base. This matters more for test suites that run on the order of days (or many hours). I'd expect the tests you've added to be called "ui tests". If some of them are also smoke tests, that's fine, but the whole set shouldn't be called "smoke tests".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5912
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)