Skip to content

Improve up build times of extension #6428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonJayamanne merged 9 commits into from
Jul 3, 2019
Merged

Improve up build times of extension #6428

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c4e42f1
Ignore certain steps and parallelize webpack
DonJayamanne Jul 3, 2019
a9a7fb5
Cache node_modules
DonJayamanne Jul 3, 2019
75ed7eb
Use existig npm
DonJayamanne Jul 3, 2019
d58ce49
Disable untill extension is enabled in org
DonJayamanne Jul 3, 2019
9aca71c
Revert unnecessary changes
DonJayamanne Jul 3, 2019
4500126
Test
DonJayamanne Jul 3, 2019
ab720f5
Fixes
DonJayamanne Jul 3, 2019
574befd
Comments
DonJayamanne Jul 3, 2019
f7840f9
Revert unnecessary changes
DonJayamanne Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,19 @@ gulp.task('compile-webviews', async () =>
);

gulp.task('webpack', async () => {
// Build node_modules and DS stuff.
await buildWebPack('production', []);
await buildWebPack('extension', ['--config', './build/webpack/webpack.extension.config.js']);
await buildWebPack('debugAdapter', ['--config', './build/webpack/webpack.debugadapter.config.js']);
// Run both in parallel, for faster process on CI.
// Yes, console would print output from both, that's ok, we have a faster CI.
// If things fail, we can run locally separately.
if (isCI) {
const buildExtension = buildWebPack('extension', ['--config', './build/webpack/webpack.extension.config.js']);
const buildDebugAdapter = buildWebPack('debugAdapter', ['--config', './build/webpack/webpack.debugadapter.config.js']);
await Promise.all([buildExtension, buildDebugAdapter]);
} else {
await buildWebPack('extension', ['--config', './build/webpack/webpack.extension.config.js']);
await buildWebPack('debugAdapter', ['--config', './build/webpack/webpack.debugadapter.config.js']);
}
});

gulp.task('updateBuildNumber', async () => {
Expand Down Expand Up @@ -218,7 +228,7 @@ gulp.task('verifyBundle', async () => {
}
});

gulp.task('prePublishBundle', gulp.series('checkNativeDependencies', 'check-datascience-dependencies', 'compile', 'clean:cleanExceptTests', 'webpack', 'renameSourceMaps'));
gulp.task('prePublishBundle', gulp.series('webpack', 'renameSourceMaps'));
gulp.task('prePublishNonBundle', gulp.series('checkNativeDependencies', 'check-datascience-dependencies', 'compile', 'compile-webviews'));

gulp.task('installPythonLibs', async () => {
Expand Down