Merged
Conversation
| "downloading.file": "Downloading {0}...", | ||
| "downloading.file.progress": "{0}{1} of {2} KB ({3})" | ||
| "downloading.file.progress": "{0}{1} of {2} KB ({3})", | ||
| "DataScience.jupyterDataRateExceeded": "Cannot view variable because your data rate is set to low. Please restart your server with a data rate limit like so `--NotebookApp.iopub_data_rate_limit=10000000000.0`" |
Member
There was a problem hiding this comment.
to [](start = 95, length = 2)
too
Member
There was a problem hiding this comment.
Also might as well update the localize.ts version when you change this. Even if that one is unlikely to be seen.
In reply to: 299094345 [](ancestors = 299094345)
rchiodo
commented
Jul 1, 2019
| previous_news = previous_news.strip() | ||
| section_title = (f"## {version} ({datetime.date.today().strftime('%d %B %Y')})" | ||
| ).replace("(0", "(") | ||
| section_title = f"## {version} ({datetime.date.today().strftime('%d %B %Y')})" |
Author
There was a problem hiding this comment.
@ericsnowcurrently @DonJayamanne I had to back out this change that Eric made. It was failing as soon as the day of the month switched to single digits.
This was causing all of the unit tests to fail
https://dev.azure.com/ms/vscode-python/_build/results?buildId=22894
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #6273
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)