Skip to content

Move test.ipynb out of root enlistment folder#6382

Merged
rchiodo merged 3 commits intomasterfrom
rchiodo/move_test_ipynb
Jun 29, 2019
Merged

Move test.ipynb out of root enlistment folder#6382
rchiodo merged 3 commits intomasterfrom
rchiodo/move_test_ipynb

Conversation

@rchiodo
Copy link
Copy Markdown

@rchiodo rchiodo commented Jun 28, 2019

For #6212

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo rchiodo self-assigned this Jun 28, 2019
Copy link
Copy Markdown
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit 32e41fa into master Jun 29, 2019
@rchiodo rchiodo deleted the rchiodo/move_test_ipynb branch June 29, 2019 00:18
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants