Conversation
| export const ChangeDirectoryCommentIdentifier = '# ms-python.python added'; // Not translated so can compare. | ||
| export const MatplotLibInit = `import matplotlib\n%matplotlib inline\n${Identifiers.MatplotLibDefaultParams} = dict(matplotlib.rcParams)\n%config InlineBackend.figure_format = 'svg'`; | ||
| export const MatplotLibInitSvg = `import matplotlib\n%matplotlib inline\n${Identifiers.MatplotLibDefaultParams} = dict(matplotlib.rcParams)\n%config InlineBackend.figure_format = 'svg'`; | ||
| export const MatplotLibInitPng = `import matplotlib\n%matplotlib inline\n${Identifiers.MatplotLibDefaultParams} = dict(matplotlib.rcParams)\n%config InlineBackend.figure_format = 'png'`; |
There was a problem hiding this comment.
Only real question on this review. Before the SVG change I don't think that we specified InlineBackend. So should the two init options be either (SVG || PNG) or (SVG || )? Like should we not specify inline at all if we don't enable the plot viewer.
There was a problem hiding this comment.
Well except that then I don't know what the output of plots is going to be. It might be SVG and then we'd show our image viewer.
Although I could change the code to check the setting where it adds the svg stuff.
Not sure. I think I'd like to start this way and see if we get any problems with it.
There was a problem hiding this comment.
There were two people that explicitly needed png. So forcing it this way solves it for them.
2 participants
For #6344
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)