Skip to content

Fix plot viewer button images#6337

Merged
rchiodo merged 4 commits intomasterfrom
rchiodo/update_plotviewer_svgs
Jun 25, 2019
Merged

Fix plot viewer button images#6337
rchiodo merged 4 commits intomasterfrom
rchiodo/update_plotviewer_svgs

Conversation

@rchiodo
Copy link
Copy Markdown

@rchiodo rchiodo commented Jun 25, 2019

For #6336

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo rchiodo self-assigned this Jun 25, 2019
IanMatthewHuff
IanMatthewHuff approved these changes Jun 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit bb6cf19 into master Jun 25, 2019
@rchiodo rchiodo deleted the rchiodo/update_plotviewer_svgs branch June 27, 2019 15:47
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

@rchiodo rchiodo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rchiodo @IanMatthewHuff