microsoft · rchiodo · Jun 24, 2019 · Jun 24, 2019
diff --git a/build/webpack/common.js b/build/webpack/common.js
@@ -27,6 +27,11 @@ exports.nodeModulesToExternalize = [
     'node-stream-zip',
     'xml2js',
     'vsls/vscode',
+    'pdfkit',
+    'crypto-js',
+    'fontkit',
+    'linebreak',
+    'png-js'
 ];
 exports.nodeModulesToReplacePaths = [
     ...exports.nodeModulesToExternalize

diff --git a/build/webpack/common.ts b/build/webpack/common.ts
@@ -29,11 +29,16 @@ export const nodeModulesToExternalize = [
     'node-stream-zip',
     'xml2js',
     'vsls/vscode',
+    'pdfkit',
+    'crypto-js',
+    'fontkit',
+    'linebreak',
+    'png-js'
 ];
 
 export const nodeModulesToReplacePaths = [
     ...nodeModulesToExternalize
-]
+];
 
 export function getDefaultPlugins(name: 'extension' | 'debugger' | 'dependencies' | 'datascience-ui') {
     const plugins = [];

diff --git a/build/webpack/pdfkit.js b/build/webpack/pdfkit.js
@@ -0,0 +1,15 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+'use strict';
+
+/*
+This file is only used when using webpack for bundling.
+We have a dummy file so that webpack doesn't fall over when trying to bundle pdfkit.
+Just point it to a dummy file (this file).
+Once webpack is done, we override the pdfkit.js file in the externalized node modules directory
+with the actual source of pdfkit that needs to be used by nodejs (our extension code).
+*/
+
+class PDFDocument {}
+module.exports = PDFDocument;
diff --git a/build/webpack/webpack.extension.config.js b/build/webpack/webpack.extension.config.js
@@ -11,6 +11,8 @@ const configFileName = path.join(constants_1.ExtensionRootDir, 'tsconfig.extensi
 // Some modules will be pre-genearted and stored in out/.. dir and they'll be referenced via NormalModuleReplacementPlugin
 // We need to ensure they do not get bundled into the output (as they are large).
 const existingModulesInOutDir = common_1.getListOfExistingModulesInOutDir();
+// tslint:disable-next-line:no-var-requires no-require-imports
+const FileManagerPlugin = require('filemanager-webpack-plugin');
 const config = {
     mode: 'production',
     target: 'node',
@@ -49,9 +51,9 @@ const config = {
                     }
                 ]
             },
-            {enforce: 'post', test: /unicode-properties[\/\\]index.js$/, loader: "transform-loader?brfs"},
-            {enforce: 'post', test: /fontkit[\/\\]index.js$/, loader: "transform-loader?brfs"},
-            {enforce: 'post', test: /linebreak[\/\\]src[\/\\]linebreaker.js/, loader: "transform-loader?brfs"}
+            { enforce: 'post', test: /unicode-properties[\/\\]index.js$/, loader: 'transform-loader?brfs' },
+            { enforce: 'post', test: /fontkit[\/\\]index.js$/, loader: 'transform-loader?brfs' },
+            { enforce: 'post', test: /linebreak[\/\\]src[\/\\]linebreaker.js/, loader: 'transform-loader?brfs' }
         ]
     },
     externals: [
@@ -60,9 +62,26 @@ const config = {
         ...existingModulesInOutDir
     ],
     plugins: [
-        ...common_1.getDefaultPlugins('extension')
+        ...common_1.getDefaultPlugins('extension'),
+        // Copy pdfkit bits after extension builds. webpack can't handle pdfkit.
+        new FileManagerPlugin({
+            onEnd: [
+                {
+                    copy: [
+                        { source: './node_modules/pdfkit/js/data/*.*', destination: './out/client/node_modules/data' },
+                        { source: './node_modules/pdfkit/js/pdfkit.js', destination: './out/client/node_modules/' }
+                    ]
+                }
+            ]
+        })
     ],
     resolve: {
+        alias:{
+            // Pointing pdfkit to a dummy js file so webpack doesn't fall over.
+            // Since pdfkit has been externalized (it gets updated with the valid code by copying the pdfkit files
+            // into the right destination).
+            'pdfkit':path.resolve(__dirname, 'pdfkit.js')
+        },
         extensions: ['.ts', '.js'],
         plugins: [
             new tsconfig_paths_webpack_plugin_1.TsconfigPathsPlugin({ configFile: configFileName })

diff --git a/build/webpack/webpack.extension.config.ts b/build/webpack/webpack.extension.config.ts
@@ -16,6 +16,9 @@ const configFileName = path.join(ExtensionRootDir, 'tsconfig.extension.json');
 // We need to ensure they do not get bundled into the output (as they are large).
 const existingModulesInOutDir = getListOfExistingModulesInOutDir();
 
+// tslint:disable-next-line:no-var-requires no-require-imports
+const FileManagerPlugin = require('filemanager-webpack-plugin');
+
 const config: Configuration = {
     mode: 'production',
     target: 'node',
@@ -53,7 +56,11 @@ const config: Configuration = {
                         loader: 'ts-loader'
                     }
                 ]
-            }
+            },
+            {enforce: 'post', test: /unicode-properties[\/\\]index.js$/, loader: 'transform-loader?brfs'},
+            {enforce: 'post', test: /fontkit[\/\\]index.js$/, loader: 'transform-loader?brfs'},
+            {enforce: 'post', test: /pdfkit[\\\/]js[\\\/].*js$/, loader: 'transform-loader?brfs'},
+            {enforce: 'post', test: /linebreak[\/\\]src[\/\\]linebreaker.js/, loader: 'transform-loader?brfs'}
         ]
     },
     externals: [
@@ -62,7 +69,18 @@ const config: Configuration = {
         ...existingModulesInOutDir
     ],
     plugins: [
-        ...getDefaultPlugins('extension')
+        ...getDefaultPlugins('extension'),
+        // Copy pdfkit bits after extension builds. webpack can't handle pdfkit.
+        new FileManagerPlugin({
+            onEnd: [
+                {
+                    copy: [
+                        { source: './node_modules/pdfkit/js/data/*.*', destination: './out/client/node_modules/data' },
+                        { source: './node_modules/pdfkit/js/pdfkit.js', destination: './out/client/node_modules/' }
+                    ]
+                }
+            ]
+        })
     ],
     resolve: {
         extensions: ['.ts', '.js'],

diff --git a/build/webpack/webpack.extension.dependencies.config.js b/build/webpack/webpack.extension.dependencies.config.js
@@ -2,10 +2,11 @@
 // Licensed under the MIT License.
 'use strict';
 Object.defineProperty(exports, "__esModule", { value: true });
+// tslint:disable-next-line: no-require-imports
+const copyWebpackPlugin = require("copy-webpack-plugin");
 const path = require("path");
 const constants_1 = require("../constants");
 const common_1 = require("./common");
-const copyWebpackPlugin = require("copy-webpack-plugin");
 const entryItems = {};
 common_1.nodeModulesToExternalize.forEach(moduleName => {
     entryItems[`node_modules/${moduleName}`] = `./node_modules/${moduleName}`;
@@ -28,7 +29,10 @@ const config = {
                         loader: path.join(__dirname, 'loaders', 'fixEvalRequire.js')
                     }
                 ]
-            }
+            },
+            { enforce: 'post', test: /unicode-properties[\/\\]index.js$/, loader: 'transform-loader?brfs' },
+            { enforce: 'post', test: /fontkit[\/\\]index.js$/, loader: 'transform-loader?brfs' },
+            { enforce: 'post', test: /linebreak[\/\\]src[\/\\]linebreaker.js/, loader: 'transform-loader?brfs' }
         ]
     },
     externals: [
@@ -48,6 +52,12 @@ const config = {
         ])
     ],
     resolve: {
+        alias:{
+            // Pointing pdfkit to a dummy js file so webpack doesn't fall over.
+            // Since pdfkit has been externalized (it gets updated with the valid code by copying the pdfkit files
+            // into the right destination).
+            'pdfkit':path.resolve(__dirname, 'pdfkit.js')
+        },
         extensions: ['.js']
     },
     output: {

diff --git a/build/webpack/webpack.extension.dependencies.config.ts b/build/webpack/webpack.extension.dependencies.config.ts
@@ -3,11 +3,12 @@
 
 'use strict';
 
+// tslint:disable-next-line: no-require-imports
+import copyWebpackPlugin = require('copy-webpack-plugin');
 import * as path from 'path';
 import * as webpack from 'webpack';
 import { ExtensionRootDir } from '../constants';
 import { getDefaultPlugins, nodeModulesToExternalize } from './common';
-import copyWebpackPlugin = require('copy-webpack-plugin');
 
 const entryItems: Record<string, string> = {};
 nodeModulesToExternalize.forEach(moduleName => {
@@ -32,7 +33,11 @@ const config: webpack.Configuration = {
                         loader: path.join(__dirname, 'loaders', 'fixEvalRequire.js')
                     }
                 ]
-            }            
+            },
+            {enforce: 'post', test: /unicode-properties[\/\\]index.js$/, loader: 'transform-loader?brfs'},
+            {enforce: 'post', test: /fontkit[\/\\]index.js$/, loader: 'transform-loader?brfs'},
+            {enforce: 'post', test: /pdfkit[\\\/]js[\\\/].*js$/, loader: 'transform-loader?brfs'},
+            {enforce: 'post', test: /linebreak[\/\\]src[\/\\]linebreaker.js/, loader: 'transform-loader?brfs'}
         ]
     },
     externals: [

diff --git a/news/2 Fixes/6277.md b/news/2 Fixes/6277.md
@@ -0,0 +1 @@
+Fix pdf export in release bits.