Skip to content

Fix vsix building#6256

Merged
rchiodo merged 1 commit intomasterfrom
rchiodo/fix_vsix
Jun 20, 2019
Merged

Fix vsix building#6256
rchiodo merged 1 commit intomasterfrom
rchiodo/fix_vsix

Conversation

@rchiodo
Copy link
Copy Markdown

@rchiodo rchiodo commented Jun 20, 2019

For #6251

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo rchiodo added the no-changelog No news entry required label Jun 20, 2019
rchiodo
rchiodo commented Jun 20, 2019
View reviewed changes
Comment thread package.json
"typemoq": "^2.1.0",
"typescript": "^3.5.2",
"typescript-formatter": "^7.1.0",
"unicode-properties": "1.1.0",
Copy link
Copy Markdown
Author

@rchiodo rchiodo Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required in order to get the webpack fix for fontkit to work.

@rchiodo rchiodo merged commit f7321ec into master Jun 20, 2019
rchiodo added a commit that referenced this pull request Jun 20, 2019
@rchiodo
Fix vsix building (#6256)
c53a3b8
@rchiodo rchiodo deleted the rchiodo/fix_vsix branch June 25, 2019 22:10
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rchiodo @IanMatthewHuff @DonJayamanne