chore(deps-dev): update Node typings and compatible TypeScript - #1683
Open
dependabot[bot] wants to merge 3 commits into
Open
chore(deps-dev): update Node typings and compatible TypeScript#1683dependabot[bot] wants to merge 3 commits into
dependabot[bot] wants to merge 3 commits into
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
requested review from
Changyong Gong (chagong),
Sheng Chen (jdneo),
Jinbo Wang (testforstephen) and
wenyt (wenytang-ms)
as code owners
September 1, 2026 21:52
dependabot
Bot
added
dependencies
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/types/node-26.2.0
branch
from
September 3, 2026 06:59
a5f902c to
181eb6e
Compare
Contributor
|
Dependabot (@dependabot) rebase |
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.18.63 to 26.2.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/types/node-26.2.0
branch
from
September 3, 2026 07:14
181eb6e to
982b75e
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
approved these changes
Sep 3, 2026
Changyong Gong (chagong)
left a comment
Changyong Gong (chagong)
left a comment
Contributor
There was a problem hiding this comment.
Approved: the Node 26 typings migration now uses the required TypeScript compiler and all checks pass.
Copilot started reviewing on behalf of
Changyong Gong (chagong)
September 3, 2026 07:30
View session
There was a problem hiding this comment.
🟡 Changes recommended
The updates introduce scope/documentation mismatches and a likely misalignment between declared Node typings and the Node.js version used in CI/runtime.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the project’s TypeScript toolchain and Node.js type definitions to newer major versions, affecting how the extension is compiled and type-checked.
Changes:
- Bump
@types/nodefrom^14.18.63to^26.2.0. - Bump
typescriptfrom^4.9.5to^5.6.3(and update lockfile accordingly). - Update CONTRIBUTING prerequisites to reflect a newer minimum Node.js version.
File summaries
| File | Description |
|---|---|
| package.json | Updates dev dependency versions for @types/node and typescript. |
| package-lock.json | Updates resolved versions/metadata for @types/node, typescript, and adds undici-types dependency for the new Node typings. |
| CONTRIBUTING.md | Updates documented Node.js prerequisite version. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "@types/lodash": "^4.17.25", | ||
| "@types/mocha": "^10.0.9", | ||
| "@types/node": "^14.18.63", | ||
| "@types/node": "^26.2.0", |
Changyong Gong (chagong)
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
A newer version of @types/node exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Copilot started reviewing on behalf of
Changyong Gong (chagong)
September 4, 2026 01:20
View session
There was a problem hiding this comment.
🔵 Needs a closer look
Node 26 typings can permit APIs unavailable on the stated Node 20 runtime baseline.
Review details
Suppressed comments (1)
package.json:1390
- The supported build/runtime baseline is Node 20 (
.github/workflows/build.yml:33,70,107andCONTRIBUTING.md:30), while this package models Node 26 APIs. Type checking can therefore accept APIs that are unavailable in the minimum extension host and only fail at runtime. Please keep@types/nodeon a 20.x release and regenerate the lockfile, or raise the actual runtime/CI baseline to Node 26.
"@types/node": "^26.2.0",
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the development type-checking toolchain:
@types/nodefrom 14.18.63 to 26.2.0 (major)@types/node26undici-typesto 8.3.0 transitivelyThe repository's Node API usage was audited against the Node 20 CI/runtime baseline; no source migrations are required. The updated compiler passes lint, compile, VSIX packaging, and all 33 extension tests.