Detect model spread cycles without over-reporting recursive model-expression aliases#10684
Draft
Copilot wants to merge 5 commits into
Draft
Detect model spread cycles without over-reporting recursive model-expression aliases#10684Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
…xpression aliases Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/00744925-833d-4200-87a1-e286c26a0369 Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/00744925-833d-4200-87a1-e286c26a0369 Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix circular reference validation for models
Detect model spread cycles without over-reporting recursive model-expression aliases
May 14, 2026
commit: |
Member
|
@copilot add changelog |
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/4bab9fe4-0624-4803-9e15-28321acb1410 Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Contributor
Author
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/4bab9fe4-0624-4803-9e15-28321acb1410 Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model-to-model spread cycles were not being validated correctly (
FoospreadsBar,BarspreadsFoo), which led to unresolved checker state instead of a proper diagnostic. At the same time, alias recursion through model expressions was being flagged too aggressively.Spread cycle validation
spread-modelself-spread diagnostic instead of ending in pending-resolution failure.Alias recursion behavior
circular-alias-type.Targeted test coverage
spread.test.ts.alias.test.tsfor recursive aliases through model expressions.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.astro.build/opt/hostedtoolcache/node/22.22.2/x64/bin/node node /home/REDACTED/work/typespec/typespec/website/node_modules/.bin/../astro/bin/astro.mjs build node s/.b�� run --local de_modules/pnpm/dist/node-gyp-bin/node import @typespecsh --production reams/reference node sion�� build.json dotnet k/typespec/typespec/node_modules/.bin/node --no-emit node rsioning/referendoc sh(dns block)If you need me to access, download, or install something from one of these locations, you can either: