Add checkovAzurePipelines sample fixture for CKV_AZUREPIPELINES_2#165
Add checkovAzurePipelines sample fixture for CKV_AZUREPIPELINES_2#165Copilot wants to merge 6 commits into
Conversation
Agent-Logs-Url: https://github.com/microsoft/security-devops-azdevops/sessions/5b5faec4-36ff-4c06-af13-179dc4a93b9d Co-authored-by: DimaBir <28827735+DimaBir@users.noreply.github.com>
…KV_AZUREPIPELINES_*
…IF path in readme
|
@copilot follow-up validation pass for this PR:
Scope constraints (unchanged from the original assignment):
Spec for reference: #164. Original review feedback that produced commits |
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot the firewall block is on Checkov's Prisma Cloud telemetry endpoint, not on anything the scan itself needs. The scan is fully local. Retry with checkov \
-f samples/checkovAzurePipelines/azure-pipelines.yml \
--framework azure_pipelines \
-o sarif \
--output-file-path /tmp/ \
--skip-downloadIf export BC_API_URL= CHECKOV_RUN_LOCAL_ONLY=trueand re-run. Both target the same thing — preventing Checkov from phoning home — but Then complete step 2 from the previous comment: append the Validation section (Checkov version, jq output, and the AC2 TODO) to the PR description. Do NOT request firewall allowlisting changes — the offline run is what we want; it matches how the MSDO task invokes Checkov in customer environments anyway. |
Re-ran offline with Both |
Deliverable #3 from #164 (split out from #163): a reusable fixture that lets reviewers verify the
CKV_AZUREPIPELINES_*severity promotion (note→warning) end-to-end against the publicMicrosoftSecurityDevOps@1task output.Changes
samples/checkovAzurePipelines/azure-pipelines.yml— minimal pipeline whose job-levelcontainer: ubuntu:latesttriggersCKV_AZUREPIPELINES_1andCKV_AZUREPIPELINES_2when Checkov scans the pipeline file, followed byMicrosoftSecurityDevOps@1withtools: 'checkov'.samples/checkovAzurePipelines/readme.md— run instructions, expected Scans Tab behavior (visible as Warning post-Guardian-change; hidden under default filter until then), and the paste-ready AC1/AC3/AC4jqsnippets lifted from the issue body.samples/readme.md— index the new sample alongside the existing ones.Structure/style mirrors
samples/IaCMapping/andsamples/trivypipeline/.Out of scope (per spec + agent instructions)
src/MicrosoftSecurityDevOps/**— fix is not in the wrapper;.gdnconfigseverity overrides are a separate feature.microsoft/security-devops-azdevops.wiki.git.Validation
Ran Checkov locally against the fixture to confirm the intended rules fire:
checkov -f samples/checkovAzurePipelines/azure-pipelines.yml \ --framework azure_pipelines -o sarif --output-file-path . jq '[.runs[0].results[] | select(.ruleId | startswith("CKV_AZUREPIPELINES_")) | .ruleId] | unique' results_sarif.sarifTODO: AC2 screenshot pending real ADO build run by a maintainer (cannot drive an Azure DevOps pipeline autonomously from this environment).