[0.82] E2Ex86 CI failure fix - #15549
Merged
Merged
Conversation
Vineeth (vineethkuttan)
changed the title
Abhijeet Jha (iamAbhi-916)
marked this pull request as ready for review
January 16, 2026 05:56
Abhijeet Jha (iamAbhi-916)
approved these changes
Jan 16, 2026
| // param: T | ||
| //return `count <= ${index} ? throw jsi::JSError(rt, "Expected argument in position ${index} to be passed") : ${expression}`; | ||
| //Windows #15545 | ||
| return `(count > ${index} || (throw jsi::JSError(rt, "Expected argument in position ${index} to be passed"), false), ${expression})`; |
Contributor
There was a problem hiding this comment.
looks good to me!
Abhijeet Jha (iamAbhi-916)
requested review from
acoates-ms and
Vladimir Morozov (vmoroz)
January 19, 2026 08:24
Vladimir Morozov (vmoroz)
approved these changes
Jan 19, 2026
Julio César Rocha (JunielKatarn)
pushed a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jun 9, 2026
* forking GenerateModuleCpp * Change files * review changes (cherry picked from commit 8b6a19d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
E2ex86 is failing because of MSVC compiler issue with the ternary operator, modified the codegen source file to generate file using comma operator.
This fix is only applicable for 0.82 , cause this file will be removed in upcoming intergration.
upstream commit: react/react-native#54059
Please validate the code changes from npm code viewer, cause the code in react native is different from published codegen package.
Type of Change
Why
This will fix our CI pipeline, and user can build x86 RNW app without any issues
Resolves [ #15545 ]
What
Modified the windows codegen to use our own custom generator instead of the file from @react-native/codegen
Testing
Tested in playground and e2e for all different arch
Changelog
Should this change be included in the release notes: yes
Modified codegen generators so that use of ternary operator will be avoided.
Microsoft Reviewers: Open in CodeFlow