Repository navigation
fix(macos): keep a press on a view from reaching a text field beneath it #3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bron Davies (brondavies)
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
brondavies:fix/view-keeps-mouse-down
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment seems a bit too driven by the context window, and I'm worried about the implications of overriding this for other scenarios where we don't want to accept the event. Copilot could you look into both making a newer comment and reviewing whether this is the right fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. Accepting it on every view was too broad, and the comment too long. Narrowed in 3302f5f:
PressablesetsmouseDownCanMoveWindow: falseon its view. A view that says a press there can't move the window is claiming the press, as AppKit's own controls do. That prop also keeps the view from being flattened.isMovableByWindowBackground, title-bar areas) and native containers hosting React Native, such as table view cells, see no change.rightMouseDown:andotherMouseDown:, which are accepted only when the view has anonAuxClickhandler.TouchableOpacityandTouchableHighlightdon't setmouseDownCanMoveWindow. I can passfalsefrom them asPressabledoes, here or in a follow-up, if you'd like.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in RNTester-macOS, built from this branch, with real clicks on a button over a
TextInputthat is being edited:Pressablefires every time.TouchableOpacityand a plainViewdon't; the click goes to the field. Both keepmouseDownCanMoveWindowYES, so that'smain's behaviour.mouseDownCanMoveWindow={false}passed fromTouchableOpacity(a local edit), it fires too, and the plainViewis unchanged.Details are in the description. Happy to add the
TouchableOpacity/TouchableHighlightpart here if you want it.