fix: prevent dev loading view clipping - #3023
Merged
Saad Najmi (Saadnajmi) merged 5 commits intoAug 3, 2026
Merged
Conversation
Tommy Nguyen (tido64)
approved these changes
Jul 14, 2026
Remove the full-size content view style from the short borderless macOS sheet so AppKit does not apply the clipped sheet frame mask. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Avoid AppKit's sheet frame mask by attaching the borderless loading banner to the key window as a centered child window. Apply the banner's rounded corners explicitly and remove matching child windows on hide. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Let a titleless full-size-content window provide the native macOS clipping shape instead of hard-coding a Core Animation corner radius. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d1aa7dab-4d8e-4c6c-a425-711e6b644559
Saad Najmi (Saadnajmi)
force-pushed
the
saadnajmi/fix-loading-view-clipping
branch
from
August 3, 2026 22:15
574b714 to
ebae083
Compare
Derive the banner radius from half its height and keep the default circular layer curve, avoiding AppKit’s pointed short-window mask. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d1aa7dab-4d8e-4c6c-a425-711e6b644559
Apply the native continuous Core Animation corner curve to the height-derived loading capsule. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d1aa7dab-4d8e-4c6c-a425-711e6b644559
Saad Najmi (Saadnajmi)
enabled auto-merge (squash)
August 3, 2026 22:26
Saad Najmi (Saadnajmi)
added a commit
that referenced
this pull request
Aug 6, 2026
## Summary Present the macOS `RCTDevLoadingView` banner as a centered child window instead of a modal sheet. AppKit masks short borderless sheets into a pointed pill shape; a child window remains attached to and follows the parent without inheriting the sheet frame mask. The banner now applies its own subtle continuous corner radius and matching child windows are detached and hidden during cleanup. ## Changelog [MACOS] [FIXED] - Prevent the development loading view from being clipped ## Test Plan <img width="826" height="226" alt="image" src="https://github.com/user-attachments/assets/3be70235-7c06-4621-8083-456316ab4af9" /> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d1aa7dab-4d8e-4c6c-a425-711e6b644559 (cherry picked from commit 78f5b04)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Present the macOS
RCTDevLoadingViewbanner as a centered child window instead of a modal sheet. AppKit masks short borderless sheets into a pointed pill shape; a child window remains attached to and follows the parent without inheriting the sheet frame mask.The banner now applies its own subtle continuous corner radius and matching child windows are detached and hidden during cleanup.
Changelog
[MACOS] [FIXED] - Prevent the development loading view from being clipped
Test Plan