This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Improving the logging of WorkspaceClientException to include more actionable information - #380
Merged
Ricardo Espinoza (ricardo-espinoza) merged 4 commits intoSep 23, 2020
Conversation
…ormative data in its message from its inner exception.
Ricardo Espinoza (ricardo-espinoza)
requested review from
Andres Paz (anpaz) and
César Zaragoza Cortés (cesarzc)
September 22, 2020 06:09
…tion.cs Co-authored-by: César Zaragoza Cortés <cesar.zaragoza@outlook.com>
César Zaragoza Cortés (cesarzc)
approved these changes
Sep 22, 2020
Ricardo Espinoza (ricardo-espinoza)
deleted the
ricardoe/bugs/output-inner-exception-fields
branch
September 23, 2020 02:42
Cassandra Granade (cgranade)
pushed a commit
that referenced
this pull request
Sep 23, 2020
…ionable information (#380) (#386) Improving the logging of WorkspaceClientException to include more informative data in its message from its inner exception. This is a follow up to #378 . - Instead of providing the full stack of the exception in the output, we extract more relevant fields from the source RestErrorException and provide them to the user. - Also, this change exposes header "x-ms-request-id"if present in the response, for additional debugging. Co-authored-by: Ricardo Espinoza <ricardoe@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving the logging of WorkspaceClientException to include more informative data in its message from its inner exception.
This is a follow up to #378 .