Update to C++17 - #310
Conversation
| #if (SAFEINT_COMPILER == CLANG_COMPILER || SAFEINT_COMPILER == GCC_COMPILER) && CPLUSPLUS_STD < CPLUSPLUS_11 | ||
| #error Must compile with --std=c++11, preferably --std=c++14 to use constexpr improvements | ||
| #if (SAFEINT_COMPILER == CLANG_COMPILER || SAFEINT_COMPILER == GCC_COMPILER) && CPLUSPLUS_STD < CPLUSPLUS_17 | ||
| #error Must compile with --std=c++17 |
There was a problem hiding this comment.
Note that this changes the build requirement for clang and gcc to C++17, where previously this file would have accepted and attempted to handle anything down to C++11. That said, the CMakeLists.txt for all the code under src\Native already had C++14 as the required standard, so I don't believe our support of C++11 was genuine here. Given that after this switch we will start incorporating C++17 only features, it felt appropriate to update this requirement too.
Dave Wecker (dbwz8)
left a comment
Dave Wecker (dbwz8)
left a comment
There was a problem hiding this comment.
I assume you've tested the build on both Windows and Linux.
|
Dave Wecker (@dbwz8) Yup, I tested these changes over here: #309. That included an actual usage of |
4 participants
This updates the CMake build configuration for the native simulator to use and require C++17. This will allow us to support C++17 specific features, such as
std::optionalandstd::any.