Describe the bug
Our simulator tests in src\Simulation\Simulators.Tests sometimes crash with an Access Violation when calling into the native simulator code.
To Reproduce
The crash is intermittent, but most often observed by QSimMultiThreading test, since that explicitly tests the multithreaded support.
Expected behavior
Tests should execute successfully
Actual behavior
Test host process crashes intermittently.
Additional context
Because psis is a global vector, it's shared across all the tests in the process, which xUnit will run in parallel. If a new test starts and goes to allocate a simulator and there are no empty slots in the vector, it triggers a call to push_back, and if another thread is accessing the vector at the same time it will get an access violation. SetSeed and the like follow the same pattern where it takes the simulator id as the first argument, then uses it like this: psis[id]->seed(s)
If the new size of the vector is greater than it's capacity, the whole internal storage is reallocated. From the push_back docs:
Data races
The container is modified.
If a reallocation happens, all contained elements are modified.
Otherwise, no existing element is accessed, and concurrently accessing or modifying them is safe.
Describe the bug
Our simulator tests in src\Simulation\Simulators.Tests sometimes crash with an Access Violation when calling into the native simulator code.
To Reproduce
The crash is intermittent, but most often observed by
QSimMultiThreadingtest, since that explicitly tests the multithreaded support.Expected behavior
Tests should execute successfully
Actual behavior
Test host process crashes intermittently.
Additional context
Because
psisis a global vector, it's shared across all the tests in the process, which xUnit will run in parallel. If a new test starts and goes to allocate a simulator and there are no empty slots in the vector, it triggers a call topush_back, and if another thread is accessing the vector at the same time it will get an access violation.SetSeedand the like follow the same pattern where it takes the simulator id as the first argument, then uses it like this:psis[id]->seed(s)If the new size of the vector is greater than it's capacity, the whole internal storage is reallocated. From the push_back docs:
Data races
The container is modified.
If a reallocation happens, all contained elements are modified.
Otherwise, no existing element is accessed, and concurrently accessing or modifying them is safe.