PLS doesn't resolve relative paths correctly

[erictraut]

The analyzer sometimes does not resolve relative paths correctly. See the screen shot below.

The problem appears to be in PathResolverSnapshot.TryFindName which contains the following lines of code:

if (lastEdge.End.IsModule) {
    return false;
}

I don't understand why this logic is needed. When I comment out these three lines, the relative paths resolve correctly and other imports also appear to resolve as expected.

[MikhailArkhipov]

@AlexanderSher owns the import subsystem.

[AlexanderSher]

I don't understand why this logic is needed.

It is required for the case when there is a folder with the name of the module.
For example, for the following file structure:

├─ package
   ├─ module
   │  └─ submodule.py
   ├─ module.py
   └─ test.py

and test.py:

from .module.submodule import TEST

import should be highlighted as invalid import.

In your case, what is the value of lastEdge.End.ModulePath in that piece of code?

if (lastEdge.End.IsModule) {
    return false;
}

[erictraut]

In the example you gave above, if the module directory contained an __init__.py file, the import from test.py should succeed. Would you expect lastEdge.End.IsModule to evaluate to false if __init__.py is present?

To answer your question. lastEdge.End.IsModule evaluates to true in my case, which is what causes the .exceptions and '.image_builder` imports to be incorrectly flagged as errors.