ci: use nodejs version that is preinstalled on 1es containers in order to avoid flaky pipeline issues while installing nodejs by Hotell · Pull Request #29552 · microsoft/fluentui

Martin Hochel (Hotell) · 2023-10-17T12:21:30Z

Previous Behavior

nodejs install within our jobs are extremely unreliable which makes whole CI very flaky.

example of failing pipeline

New Behavior

we use only nodejs that is being shipped with 1es container
yarn@1 is part of this container so there is no need to install it manually

Related Issue(s)

Fixes #

…r to avoid flaky pipeline issues while installing nodejs

Fluent UI Team (fabricteam) · 2023-10-17T12:38:53Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `330 B`
`global-context` createContextSelector	`537 B` `342 B`
`priority-overflow` createOverflowManager	`4.162 kB` `1.735 kB`
`react-accordion` Accordion (including children components)	`93.227 kB` `28.402 kB`
`react-alert` Alert	`84.293 kB` `23.456 kB`
`react-avatar` Avatar	`50.534 kB` `15.923 kB`
`react-avatar` AvatarGroup	`20.064 kB` `7.894 kB`
`react-avatar` AvatarGroupItem	`65.19 kB` `20.259 kB`
`react-badge` Badge	`27.264 kB` `8.808 kB`
`react-badge` CounterBadge	`28.165 kB` `9.101 kB`
`react-badge` PresenceBadge	`25.67 kB` `9.313 kB`
`react-button` Button	`40.074 kB` `11.292 kB`
`react-button` CompoundButton	`47.43 kB` `12.787 kB`
`react-button` MenuButton	`44.848 kB` `12.668 kB`
`react-button` SplitButton	`52.862 kB` `14.254 kB`
`react-button` ToggleButton	`57.122 kB` `13.194 kB`
`react-card` Card - All	`93.032 kB` `26.934 kB`
`react-card` Card	`87.856 kB` `25.435 kB`
`react-card` CardFooter	`13.423 kB` `5.481 kB`
`react-card` CardHeader	`15.666 kB` `6.235 kB`
`react-card` CardPreview	`14.374 kB` `5.854 kB`
`react-checkbox` Checkbox	`37.505 kB` `12.327 kB`
`react-combobox` Combobox (including child components)	`91.84 kB` `29.937 kB`
`react-combobox` Dropdown (including child components)	`90.282 kB` `29.595 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`70.061 kB` `20.164 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`207.809 kB` `59.71 kB`
`react-components` react-components: FluentProvider & webLightTheme	`42.345 kB` `13.999 kB`
`react-datepicker-compat` DatePicker Compat	`212.163 kB` `59.148 kB`
`react-dialog` Dialog (including children components)	`89.781 kB` `26.759 kB`
`react-divider` Divider	`21.179 kB` `7.839 kB`
`react-field` Field	`22.788 kB` `8.639 kB`
`react-image` Image	`16.096 kB` `6.317 kB`
`react-infobutton` InfoButton	`130.581 kB` `41.108 kB`
`react-infobutton` InfoLabel	`134.265 kB` `42.271 kB`
`react-input` Input	`27.247 kB` `9.194 kB`
`react-jsx-runtime` Classic Pragma	`1.049 kB` `531 B`
`react-jsx-runtime` JSX Dev Runtime	`4.14 kB` `1.741 kB`
`react-jsx-runtime` JSX Runtime	`4.734 kB` `1.983 kB`
`react-label` Label	`14.508 kB` `5.857 kB`
`react-link` Link	`17.4 kB` `6.977 kB`
`react-menu` Menu (including children components)	`140.404 kB` `43.358 kB`
`react-menu` Menu (including selectable components)	`143.09 kB` `43.871 kB`
`react-message-bar` MessageBar (all components)	`25.54 kB` `9.102 kB`
`react-overflow` hooks only	`12.419 kB` `4.687 kB`
`react-persona` Persona	`57.425 kB` `17.798 kB`
`react-popover` Popover	`119.313 kB` `37.636 kB`
`react-portal` Portal	`12.458 kB` `4.537 kB`
`react-portal-compat` PortalCompatProvider	`6.706 kB` `2.25 kB`
`react-positioning` usePositioning	`25.305 kB` `9.162 kB`
`react-progress` ProgressBar	`17.788 kB` `6.986 kB`
`react-provider` FluentProvider	`22.89 kB` `8.428 kB`
`react-radio` Radio	`31.266 kB` `10.267 kB`
`react-radio` RadioGroup	`15.704 kB` `6.35 kB`
`react-select` Select	`28.968 kB` `10.269 kB`
`react-slider` Slider	`38.349 kB` `12.595 kB`
`react-spinbutton` SpinButton	`37.133 kB` `11.856 kB`
`react-spinner` Spinner	`23.762 kB` `8.556 kB`
`react-switch` Switch	`33.731 kB` `10.899 kB`
`react-table` DataGrid	`157.173 kB` `43.847 kB`
`react-table` Table (Primitives only)	`44 kB` `13.758 kB`
`react-table` Table as DataGrid	`130.468 kB` `35.186 kB`
`react-table` Table (Selection only)	`75.836 kB` `20.473 kB`
`react-table` Table (Sort only)	`74.443 kB` `20.073 kB`
`react-tags` InteractionTag	`15.618 kB` `6.152 kB`
`react-tags` Tag	`30.341 kB` `9.505 kB`
`react-tags` TagGroup	`74.06 kB` `22.091 kB`
`react-text` Text - Default	`17.065 kB` `6.645 kB`
`react-text` Text - Wrappers	`20.237 kB` `6.965 kB`
`react-textarea` Textarea	`31.306 kB` `10.549 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.611 kB` `7.295 kB`
`react-theme` Teams: Light theme	`19.282 kB` `5.486 kB`
`react-toast` Toast (including Toaster)	`92.681 kB` `27.76 kB`
`react-tooltip` Tooltip	`52.525 kB` `18.46 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 4dc9e5be60b6ce6f3f6c72c6da39bf19a504f524}

codesandbox-ci · 2023-10-17T12:51:22Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1755461:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

Fluent UI Team (fabricteam) · 2023-10-17T12:51:36Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
InfoButton	mount	11	13	5000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	607	615	5000
Button	mount	299	321	5000
Field	mount	1124	1087	5000
FluentProvider	mount	690	719	5000
FluentProviderWithTheme	mount	82	88	10
FluentProviderWithTheme	virtual-rerender	71	71	10
FluentProviderWithTheme	virtual-rerender-with-unmount	76	80	10
InfoButton	mount	11	13	5000	Possible regression
MakeStyles	mount	847	861	50000
Persona	mount	1735	1702	5000
SpinButton	mount	1371	1356	5000

Fluent UI Team (fabricteam) · 2023-10-17T12:51:57Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ChatDuplicateMessagesPerf.default	158	145	1.09:1
AttachmentMinimalPerf.default	88	82	1.07:1
LayoutMinimalPerf.default	201	190	1.06:1
StatusMinimalPerf.default	402	379	1.06:1
LoaderMinimalPerf.default	195	186	1.05:1
ChatMinimalPerf.default	437	419	1.04:1
FormMinimalPerf.default	214	206	1.04:1
GridMinimalPerf.default	186	178	1.04:1
SkeletonMinimalPerf.default	192	184	1.04:1
IconMinimalPerf.default	381	368	1.04:1
TableManyItemsPerf.default	1086	1049	1.04:1
AvatarMinimalPerf.default	106	103	1.03:1
CheckboxMinimalPerf.default	1121	1092	1.03:1
InputMinimalPerf.default	547	531	1.03:1
SegmentMinimalPerf.default	193	188	1.03:1
TooltipMinimalPerf.default	1277	1234	1.03:1
VideoMinimalPerf.default	439	428	1.03:1
ButtonOverridesMissPerf.default	652	639	1.02:1
ButtonSlotsPerf.default	313	306	1.02:1
CardMinimalPerf.default	322	317	1.02:1
DividerMinimalPerf.default	201	197	1.02:1
ItemLayoutMinimalPerf.default	703	689	1.02:1
ListMinimalPerf.default	304	298	1.02:1
MenuButtonMinimalPerf.default	951	929	1.02:1
PortalMinimalPerf.default	87	85	1.02:1
ProviderMinimalPerf.default	198	194	1.02:1
SplitButtonMinimalPerf.default	2252	2217	1.02:1
TreeMinimalPerf.default	471	460	1.02:1
AttachmentSlotsPerf.default	638	631	1.01:1
DatepickerMinimalPerf.default	3555	3515	1.01:1
DropdownMinimalPerf.default	1385	1371	1.01:1
FlexMinimalPerf.default	154	152	1.01:1
ImageMinimalPerf.default	219	216	1.01:1
ListNestedPerf.default	321	318	1.01:1
RosterPerf.default	1526	1513	1.01:1
RadioGroupMinimalPerf.default	261	258	1.01:1
SliderMinimalPerf.default	743	736	1.01:1
TableMinimalPerf.default	236	233	1.01:1
TextMinimalPerf.default	195	193	1.01:1
CustomToolbarPrototype.default	1464	1446	1.01:1
ToolbarMinimalPerf.default	524	520	1.01:1
AccordionMinimalPerf.default	81	81	1:1
DialogMinimalPerf.default	425	424	1:1
EmbedMinimalPerf.default	1809	1815	1:1
LabelMinimalPerf.default	214	213	1:1
MenuMinimalPerf.default	492	491	1:1
AnimationMinimalPerf.default	287	289	0.99:1
ListCommonPerf.default	379	384	0.99:1
ProviderMergeThemesPerf.default	640	645	0.99:1
DropdownManyItemsPerf.default	389	397	0.98:1
RefMinimalPerf.default	105	107	0.98:1
TextAreaMinimalPerf.default	285	292	0.98:1
TreeWith60ListItems.default	82	84	0.98:1
BoxMinimalPerf.default	183	188	0.97:1
CarouselMinimalPerf.default	253	261	0.97:1
PopupMinimalPerf.default	340	349	0.97:1
ReactionMinimalPerf.default	199	206	0.97:1
ChatWithPopoverPerf.default	186	193	0.96:1
HeaderMinimalPerf.default	193	201	0.96:1
HeaderSlotsPerf.default	439	461	0.95:1
ListWith60ListItems.default	338	357	0.95:1
AlertMinimalPerf.default	144	153	0.94:1
ButtonMinimalPerf.default	82	88	0.93:1

Fluent UI Team (fabricteam) · 2023-10-17T12:52:56Z

🕵 fluentuiv8 No visual regressions between this PR and main

Fluent UI Team (fabricteam) · 2023-10-17T12:57:36Z

🕵 FluentUIV0 No visual regressions between this PR and main

Fluent UI Team (fabricteam) · 2023-10-17T13:01:57Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	636	638	5000
Breadcrumb	mount	1651	1668	1000
Checkbox	mount	1648	1662	5000
CheckboxBase	mount	1455	1463	5000
ChoiceGroup	mount	2918	2937	5000
ComboBox	mount	649	657	1000
CommandBar	mount	6131	6164	1000
ContextualMenu	mount	11932	12021	1000
DefaultButton	mount	738	738	5000
DetailsRow	mount	2174	2150	5000
DetailsRowFast	mount	2191	2188	5000
DetailsRowNoStyles	mount	1951	1972	5000
Dialog	mount	2605	2632	1000
DocumentCardTitle	mount	238	223	1000
Dropdown	mount	1942	1944	5000
FocusTrapZone	mount	1125	1119	5000
FocusZone	mount	1036	1060	5000
GroupedList	mount	40987	40913	2
GroupedList	virtual-rerender	19801	19735	2
GroupedList	virtual-rerender-with-unmount	49872	49833	2
GroupedListV2	mount	222	221	2
GroupedListV2	virtual-rerender	207	216	2
GroupedListV2	virtual-rerender-with-unmount	231	228	2
IconButton	mount	1093	1080	5000
Label	mount	337	332	5000
Layer	mount	2716	2714	5000
Link	mount	380	384	5000
MenuButton	mount	937	901	5000
MessageBar	mount	21437	21304	5000
Nav	mount	1914	1932	1000
OverflowSet	mount	792	780	5000
Panel	mount	1843	1805	1000
Persona	mount	745	733	1000
Pivot	mount	858	844	1000
PrimaryButton	mount	825	829	5000
Rating	mount	4572	4516	5000
SearchBox	mount	884	906	5000
Shimmer	mount	1845	1893	5000
Slider	mount	1300	1313	5000
SpinButton	mount	2829	2839	5000
Spinner	mount	383	389	5000
SplitButton	mount	1799	1812	5000
Stack	mount	409	397	5000
StackWithIntrinsicChildren	mount	857	840	5000
StackWithTextChildren	mount	2577	2560	5000
SwatchColorPicker	mount	6101	6098	5000
TagPicker	mount	1446	1455	5000
Text	mount	366	364	5000
TextField	mount	946	922	5000
ThemeProvider	mount	829	820	5000
ThemeProvider	virtual-rerender	583	570	5000
ThemeProvider	virtual-rerender-with-unmount	1256	1241	5000
Toggle	mount	621	616	5000
buttonNative	mount	187	193	5000

Fluent UI Team (fabricteam) · 2023-10-17T13:02:13Z

🕵 fluentuiv9 No visual regressions between this PR and main

size-auditor · 2023-10-17T13:02:28Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4dc9e5be60b6ce6f3f6c72c6da39bf19a504f524 (build)

…in order to avoid flaky pipeline issues while installing nodejs

…ainers in order to avoid flaky pipeline issues while installing nodejs

github-actions Bot added this to the October Project Cycle Q4 2023 milestone Oct 17, 2023

Martin Hochel (Hotell) added Area: Build System CI labels Oct 17, 2023

Martin Hochel (Hotell) changed the title ~~ci: use nodejs version that is preinstalled on 1es containers in orde…~~ ci: use nodejs version that is preinstalled on 1es containers in order to avoid flaky pipeline issues while installing nodejs Oct 17, 2023

Martin Hochel (Hotell) force-pushed the hotell/node/bump-to-latest-16 branch from 27fd0bd to 6260173 Compare October 17, 2023 12:33

ci: use nodejs version that is preinstalled on 1es containers in orde…

a855fdf

…r to avoid flaky pipeline issues while installing nodejs

Martin Hochel (Hotell) force-pushed the hotell/node/bump-to-latest-16 branch from 6260173 to a855fdf Compare October 17, 2023 12:38

ci: dont manually install yarn@1 which is shipped within 1es container

69435cc

Martin Hochel (Hotell) force-pushed the hotell/node/bump-to-latest-16 branch from 551e629 to 69435cc Compare October 17, 2023 13:53

fixup! ci: use nodejs version that is preinstalled on 1es containers …

b1291d6

…in order to avoid flaky pipeline issues while installing nodejs

Martin Hochel (Hotell) marked this pull request as ready for review October 17, 2023 14:16

Martin Hochel (Hotell) requested a review from a team as a code owner October 17, 2023 14:16

fixup! fixup! ci: use nodejs version that is preinstalled on 1es cont…

1755461

…ainers in order to avoid flaky pipeline issues while installing nodejs

Tristan Watanabe (TristanWatanabe) approved these changes Oct 17, 2023

View reviewed changes

Martin Hochel (Hotell) merged commit 842ed68 into microsoft:master Oct 18, 2023

Martin Hochel (Hotell) deleted the hotell/node/bump-to-latest-16 branch October 18, 2023 07:57

Martin Hochel (Hotell) mentioned this pull request Oct 18, 2023

SLOW OR FAILED (500 ERROR) NODE.JS DOWNLOADS nodejs/nodejs.org#4495

Closed

Navigation Menu

Repository navigation

ci: use nodejs version that is preinstalled on 1es containers in order to avoid flaky pipeline issues while installing nodejs - #29552

ci: use nodejs version that is preinstalled on 1es containers in order to avoid flaky pipeline issues while installing nodejs#29552
Martin Hochel (Hotell) merged 4 commits into
microsoft:masterfrom
Hotell:hotell/node/bump-to-latest-16

Martin Hochel (Hotell) commented Oct 17, 2023 •

edited

Loading

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Oct 17, 2023 •

edited

Loading

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Uh oh!

size-auditor Bot commented Oct 17, 2023 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Martin Hochel (Hotell) commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

codesandbox-ci Bot commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Fluent UI Team (fabricteam) commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

size-auditor Bot commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Martin Hochel (Hotell) commented Oct 17, 2023 •

edited

Loading

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

codesandbox-ci Bot commented Oct 17, 2023 •

edited

Loading

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Fluent UI Team (fabricteam) commented Oct 17, 2023 •

edited

Loading

size-auditor Bot commented Oct 17, 2023 •

edited

Loading