Repository navigation
Add macOS Paper Storybook mode and PR coverage - #4355
Open
Jason Morse (JasonVMo) wants to merge 12 commits into
Open
Jason Morse (JasonVMo) wants to merge 12 commits into
Jason Morse (JasonVMo) wants to merge 12 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…a pipeline run for it
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Fix the macOS Paper CI geometry failure without relaxing its native alignment assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Compare Text line boxes with the same Paper pixel-rounding policy, preserve the native assertions, and remove the ineffective max-width production change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align locked React, theming, and UI-common packages after the main-branch UI upgrades while preserving strict Metro duplicate checks and existing dependency ranges. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Originally stacked on #4354; the parent has merged and this PR now targets
main.--macos --paperto the shared Storybook CLI and a matchingpaperAPI option. Fabric remains the default; Windows/Win32 reject the flag.prepwhen switching the shared generated native project between renderers.Related upstream bug: microsoft/react-native-macos#3121. This is a story-only workaround, not a fix for the upstream native baseline callback.
Verification
Hosted run 37089117508 at
21f75691fpasses macOS Paper Storybook PR, macOS Storybook PR, Windows Storybook PR, Win32 Storybook PR, and JS PR. Each macOS renderer job renders all 168 stories and reports 30 authored cases: 7 passed and 23 explicit capability skips. The formerly failing LayoutStableText native alignment case passes in both renderer jobs.Root/workspace commands were run from the repository root:
yarn lint-repoyarn buildyarn change:checkyarn dedupe '@storybook/*' storybook --checkyarn workspace @fluentui-react-native/storybook-desktop lintyarn workspace @fluentui-react-native/storybook-desktop buildyarn workspace @fluentui-react-native/storybook-desktop test --runInBandyarn workspace @fluentui-react-native/components lintyarn workspace @fluentui-react-native/components buildyarn workspace @fluentui-react-native/components test --runInBand --testNamePattern CompoundItemLayoutyarn workspace @fluentui-react-native/components test --runInBand --testNamePattern 'LayoutStableText|Button|Tab'yarn workspace @fluentui-react-native/agentic-components-storybook formatyarn workspace @fluentui-react-native/agentic-components-storybook lintyarn workspace @fluentui-react-native/storybook-desktop-runtime lintyarn workspace @fluentui-react-native/storybook-desktop-runtime test --runInBandNative commands were run from
apps/storybook:yarn storybook prep --macos --paperyarn storybook bundle --macos --paperyarn storybook bundle --windowsyarn storybook bundle --win32yarn storybook build --macos --paperFURN_DESKTOP_DRIVER_DISABLED_INPUT_FEATURES=physicalClick yarn storybook smoke --macos --paper --mode stories-and-testsyarn storybook prep --macosFURN_DESKTOP_DRIVER_DISABLED_INPUT_FEATURES=physicalClick yarn storybook smoke --macos --mode stories-and-testsThe initial Paper sweep exposed the upstream native baseline abort. Hosted Paper CI subsequently rendered all 168 stories but failed the LayoutStableText width assertion by comparing a 104-point Text frame with a 102-point wrapper View. A trial maximum-width style did not change that result and has been removed. The final fixture compares the actual hidden reserve Text and visible Text, without weakening assertions or changing production layout. Concurrent dependency upgrades on main then blocked both macOS renderer jobs at bundling; deduplicating existing compatible locked packages restores all three desktop bundles without disabling validation. The final local Paper sweep used freshly regenerated Pods and a clean app-specific native build. Both local renderer sweeps passed, and all four hosted desktop Storybook jobs now pass. Capability skips are not claimed as executed native-state/input qualification. Windows/Win32 native lifecycles were not run locally; VoiceOver was not qualified.
--macos --paperenables the Paper lifecycle and dedicated PR coverage.Pull request checklist
This PR has considered (when applicable):