Repository navigation
Add maximumFontSize - #2389
Merged
Adam Gleitman (amgleitman) merged 11 commits intoDec 15, 2022
Merged
Add maximumFontSize#2389
Conversation
Contributor
|
Talked offline - seems like it might be a little unclear to someone who has no context what maximumFontSize is on what the Disp (<= 70) is testing. Maybe making a new section called "maximum font size" and giving a short description on what it is would be more clear. |
Lynn Zhang (lyzhan7)
approved these changes
Dec 14, 2022
Lynn Zhang (lyzhan7)
left a comment
Contributor
There was a problem hiding this comment.
Besides updating the test page to be more clear this looks good to me. I am wondering though if we should have a discussion about Mike's suggestion before merging? If it's another possible approach maybe it would replace this PR.
Saad Najmi (Saadnajmi)
approved these changes
Dec 14, 2022
Saad Najmi (Saadnajmi)
left a comment
Collaborator
There was a problem hiding this comment.
Approved with minor comments
added 8 commits
December 14, 2022 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This adds a
maximumFontSizetoken that can cap the size of Dynamic Type text.Verification
Added an example to the TextV2 test page. The text takes up (roughly) the entirety of the width of an iPhone 14 Pro at its maximum size, as seen below.
UIContentSizeCategoryLargeUIContentSizeCategoryAccessibilityLarge(AX2)Pull request checklist
This PR has considered (when applicable):