Skip to content

Infrastructure: Tighten Storybook manifest provenance and native helper trust handoff #4445

Closed

Description

@JasonVMo

Status: Done

Landed in #4490: strict, versioned v3 generated contracts that reject unknown fields; independent bridge and attachment credentials in owner-private storage (POSIX 0700/0600, Windows protected-DACL), with only bridge data projected into Metro; helper provenance pinned through an independent parent handoff and re-verified by the channel child that actually spawns it; and controlled Metro generation fixtures. Windows Fabric and Win32 Paper native Storybook lanes passed.

Residual macOS Fabric and macOS Paper requalification of these paths (the macOS consumer smokes were Accessibility-blocked for this change) lives in #4441.

Goal

Native helper provenance crosses an editable generated manifest, the macOS attach lease and the runtime bridge reuse the same nonce, and generated schemas are not centralized or versioned. Tighten the trust handoff so tampered artifacts fail before spawn and each secret has one purpose.

Part of #4435 (plan item F6).

Scope

  • Owner: Storybook generated configuration.
  • Paths (under packages/agentic/): storybook-desktop/src/driver/driverManifest.ts, nonce and lease handling in storybook-desktop/src/cli/DesktopStorybookCli.ts, storybook-desktop/config/server.cjs, storybook-desktop-runtime/config/metro.cjs, and controlled config fixtures.
  • Separate runtime bridge and attach-credential secrets.
  • Centralize and version generated schemas; reject unknown manifest fields.
  • Reverify helper provenance in the process that actually spawns it. A hash stored in the same editable record is not independent trust.
  • Exercise Metro generation only in controlled fixtures, because loading its config has write effects.

Dependencies

Acceptance

  • Tampered or mismatched artifacts fail before spawn. (#4490)
  • Unknown manifest fields fail. (#4490)
  • Bridge and attach nonces are independent. (#4490)
  • Secrets use owner-private POSIX modes and the appropriate Windows ACL or private-storage boundary. (#4490)

Validation

  • Iterate with focused yarn test <name> in each changed package, then run its yarn format, yarn lint, yarn build, and yarn test. Finish with yarn clean-lage-cache then yarn lage buildci; run yarn lage test-links --verbose --grouped after markdown changes.
  • Add a patch changeset for each changed published package. Update the affected topic section and its status-overview line in the owning references/current-status.md, and affected README/AGENTS guidance, in the same change.
  • Native, provider, or process-topology changes need matching-OS native contracts and the affected consumer lane. JavaScript tests and bundles do not qualify native behavior; hosted capability skips are not passes. Report each check as passed, failed, skipped, not run, or unsupported.

Evidence

  • Current state: per-run evidence is recorded in the pull request description or an issue comment (#4490); each package's references/current-status.md keeps a status overview, stable topic sections, and only the latest result per native endpoint with a link.
  • Retired plan: driver-next.md at 0569e1b86, section 8 (F6).

Activity

  1. JasonVMo commented on Nov 16, 2026

    @JasonVMo
    ContributorAuthor

    Closing as completed by #4490.

    Acceptance:

    • Tampered or mismatched artifacts fail before spawn: the channel child that spawns the helper re-verifies it against an independent parent handoff, and fixtures reject substituted helper path, hash and bytes and manifest/runtime tampering.
    • Unknown manifest fields fail: generated contracts are strict, versioned v3 and use one shared parser.
    • Bridge and attach nonces are independent: v3 manifests carry neither, and each credential is separate and owner-private; only bridge data reaches Metro.
    • Private storage: macOS 0700/0600 with permissive-mode refusal; Windows protected-DACL storage, with the NTFS private-storage contract passing in CI.

    Native evidence: Windows Fabric and Win32 Paper (accessible and physical) native Storybook lanes passed in CI. The macOS Fabric and Paper consumer smokes for this change were blocked on Accessibility and executed no tests, so macOS is not claimed. The PowerShell parser check was not run.

    Residual moved: macOS Fabric and macOS Paper requalification of the v3 manifest/credential handoff, channel-child helper re-verification and live authenticated bridge now lives in #4441 (macOS requalification item).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions