Conversation
ef768b2 to
64ebc96
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
64ebc96 to
a2da7fd
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new slotted test fixture to @microsoft/fast-html and wires it into the existing @microsoft/fast-build-based fixture build pipeline so its index.html is generated consistently with the other fast-build fixtures.
Changes:
- Added
slottedfixture inputs (entry.html,templates.html,state.json) and generated output (index.html). - Updated
packages/fast-html/scripts/build-fixtures.jsto includeslottedin the fixtures built via@microsoft/fast-build. - Added a Beachball change file documenting the chore-level update.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/fast-html/test/fixtures/slotted/templates.html | Defines f-slotted usages to exercise default and named slot configurations with filters. |
| packages/fast-html/test/fixtures/slotted/state.json | Provides the fixture state input for the fast-build CLI (empty object). |
| packages/fast-html/test/fixtures/slotted/index.html | Generated HTML output showing f-slotted stripped from DSD while preserving data-fe-c-* hydration bindings. |
| packages/fast-html/test/fixtures/slotted/entry.html | Entry HTML used as input to build the fixture output via fast-build. |
| packages/fast-html/scripts/build-fixtures.js | Adds slotted to the fast-build fixture build list. |
| change/@microsoft-fast-html-slotted-fdec5a05-d62e-45dd-92a7-e47213d20812.json | Records the change in the repo’s change management system (Beachball). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds the
slottedtest fixture to@microsoft/fast-htmland generates itsindex.htmlusing@microsoft/fast-build, consistent with the other fixtures (attribute,binding,event).The
slottedfixture coversf-slottedattribute directives, which bind references to slotted child nodes in a FAST template (e.g.<slot f-slotted="{slottedNodes filter elements()}"></slot>). Becausef-slottedis client-side only,@microsoft/fast-buildstrips it from the rendered Declarative Shadow DOM while preserving thedata-fe-chydration binding count so the FAST runtime can allocate the correct number of binding slots.The fixture exercises three slot configurations:
f-slotted="{slottedNodes filter elements()}"<slot name="foo" f-slotted="{slottedFooNodes}"><slot name="bar" f-slotted="{slottedBarNodes filter elements(p, ol)}">🎫 Issues
No open issues directly addressed.
📑 Test Plan
npm run build:fixturesinpackages/fast-htmlruns cleanly and regeneratesslotted/index.html—f-slotteddirectives are stripped from shadow DOM output,data-fe-cbinding annotations are preserved on each slot.attribute,binding,event) are unchanged.✅ Checklist
General
$ npm run change⏭ Next Steps
slotted.spec.ts) covering hydration of thef-slottedfixture to verify client-side slotted node reference assignment after SSR.