Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the @microsoft/fast-html event Playwright fixture to be generated via @microsoft/fast-build, aligning it with the newer fixture build workflow used by other fixtures in this package.
Changes:
- Adds
entry.html,templates.html, andstate.jsoninputs for theeventfixture. - Replaces the
eventfixture’sindex.htmlwith fast-build output and injected<f-template>declarations. - Includes
eventinpackages/fast-html/scripts/build-fixtures.js’s fixture build list and adds a Beachball change file.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/fast-html/test/fixtures/event/templates.html | Adds the event-binding template source used for fixture generation. |
| packages/fast-html/test/fixtures/event/state.json | Adds fixture state used for rendering (foo: bar). |
| packages/fast-html/test/fixtures/event/entry.html | Adds the entry HTML used by fast-build to generate index.html. |
| packages/fast-html/test/fixtures/event/index.html | Updates fixture output to fast-build generated HTML plus injected templates. |
| packages/fast-html/scripts/build-fixtures.js | Adds event to the fast-build fixture generation list. |
| change/@microsoft-fast-html-event-26bc183e-be69-4199-a9f7-1cdd8a87d25e.json | Records the change for Beachball/versioning. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
@microsoft/fast-buildto generate theindex.htmlfor theeventtest fixture in@microsoft/fast-html.