Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

entity definition of missing entity type will be included in simpleIntentSection#908

Closed
feich-ms wants to merge 2 commits into
masterfrom
feich/fixParseIssue
Closed

entity definition of missing entity type will be included in simpleIntentSection#908
feich-ms wants to merge 2 commits into
masterfrom
feich/fixParseIssue

Conversation

@feich-ms
Copy link
Copy Markdown
Contributor

fix #907. Before the fix, entity line of '$a' after a intent will not be included into simpleIntentSection. After the fix, it will be included as body of the simpleIntentSection and fill an error in parse Errors. This will help composer lu editor.

@feich-ms feich-ms requested a review from munozemilio as a code owner July 20, 2020 08:38
@feich-ms feich-ms requested a review from boydc2014 July 20, 2020 09:38
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #908 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   56.60%   56.59%   -0.02%     
==========================================
  Files         220      220              
  Lines       15747    15833      +86     
  Branches     2241     2230      -11     
==========================================
+ Hits         8914     8960      +46     
- Misses       6264     6310      +46     
+ Partials      569      563       -6     
Impacted Files Coverage Δ
packages/luis/src/commands/luis/index.ts 66.66% <0.00%> (-16.67%) ⬇️
...kages/qnamaker/src/commands/qnamaker/kb/publish.ts 85.71% <0.00%> (-14.29%) ⬇️
...aker/src/commands/qnamaker/endpointkeys/refresh.ts 85.71% <0.00%> (-14.29%) ⬇️
...atics/confusion_matrix/AppBinaryConfusionMatrix.ts 85.71% <0.00%> (-14.29%) ⬇️
...ematics/mathematics_helper/AppMathematicsHelper.ts 86.36% <0.00%> (-13.64%) ⬇️
packages/qnamaker/src/utils/qnamakerbase.ts 71.64% <0.00%> (-8.72%) ⬇️
packages/qnamaker/src/commands/qnamaker/query.ts 41.93% <0.00%> (-8.07%) ⬇️
...ispatcher/src/data/AppEntityAnnotatedCorpusData.ts 92.00% <0.00%> (-8.00%) ⬇️
...kages/qnamaker/src/commands/qnamaker/kb/replace.ts 79.31% <0.00%> (-7.65%) ⬇️
...ckages/qnamaker/src/commands/qnamaker/kb/delete.ts 86.95% <0.00%> (-6.80%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a2a42...99cb185. Read the comment docs.

@feich-ms feich-ms requested a review from vishwacsena July 21, 2020 02:33
@feich-ms
Copy link
Copy Markdown
Contributor Author

Close this one since it is already merged into PR #910 as #910 is also optimizing lu parser.

@feich-ms feich-ms closed this Jul 22, 2020
@feich-ms feich-ms deleted the feich/fixParseIssue branch October 13, 2020 02:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LU parser update body not correct.

2 participants