This repository was archived by the owner on Jan 15, 2025. It is now read-only.
entity definition of missing entity type will be included in simpleIntentSection#908
Closed
feich-ms wants to merge 2 commits into
Closed
entity definition of missing entity type will be included in simpleIntentSection#908feich-ms wants to merge 2 commits into
feich-ms wants to merge 2 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #908 +/- ##
==========================================
- Coverage 56.60% 56.59% -0.02%
==========================================
Files 220 220
Lines 15747 15833 +86
Branches 2241 2230 -11
==========================================
+ Hits 8914 8960 +46
- Misses 6264 6310 +46
+ Partials 569 563 -6
Continue to review full report at Codecov.
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #907. Before the fix, entity line of '$a' after a intent will not be included into simpleIntentSection. After the fix, it will be included as body of the simpleIntentSection and fill an error in parse Errors. This will help composer lu editor.