Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

bf-orchestrator should not swallow errors #1270

@chrimc62

Description

@chrimc62

Versions

@microsoft/bf-orchestrator-cli 4.14.1

Describe the bug

Orchestrator should not swallow underlying errors. For example in OrchestratorHelp.ts you see this code:

    } catch (error) {
      throw new Error(`Failed to parse ${filePath}`);
    }

This means you have no idea why parsing failed because error is not reflected.

To Reproduce

Steps to reproduce the behavior:

  1. Create an LU file with improper syntax
  2. bf orchestrator:create with that file

Expected behavior

You should see underlying parsing errors.

[bug]

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIndicates an unexpected problem or an unintended behavior.needs-triageThe issue has just been created and it has not been reviewed by the team.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions