Use jupyer-kernel-gateway for ipython executor#1748
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1748 +/- ##
==========================================
+ Coverage 39.13% 47.95% +8.82%
==========================================
Files 57 62 +5
Lines 6174 6473 +299
Branches 1384 1554 +170
==========================================
+ Hits 2416 3104 +688
+ Misses 3564 3118 -446
- Partials 194 251 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Most of these change should be covered by the existing tests - but I don't think they are running since the dependencies are missing on the build machines |
|
Just a nit. Approved. Let's open an issue to track the upstream bug fix to the jupyter gateway client. |
|
Upstream bug fix being tracked here #1763 |
|
I am very confused how this PR affects me as an end user? Can you please provide examples. |
|
This is part of a larger whole (including a docker based jupyter server), examples and docs will come with a later PR in the series |
gagb
left a comment
There was a problem hiding this comment.
This PR works. Lets improve the syntax of updating system messages via introductions in a different PR.
Why are these changes needed?
This uses the jupyter-kernel-gateway to manage kernels for the ipython based executor. This is desirable as it allows us to have a common interface to interact with kernels irrespective of where they are executing. In this PR I migrate the embedded executor. I will follow this up with a docker container based version.
Related issue number
#1421
Checks